Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[birt-dev] CHECKIN: [149099] ODA Parameter Default Value is mis-handled as Javascript expression

Title: CHECKIN: [149099] ODA Parameter Default Value is mis-handled as _javascript_ _expression_

Summary:
Adapts an ODA Parameter Default Value as a literal string before applying the value in a ROM data set parameter.

Bugzilla Entry(ies) Resolved:
149099

Description:
When a custom ODA designer defines an oda Data Set Design that has a data set
parameter with default value, the value should be handled as a literal value,
and not a _javascript_ _expression_.

This fix adds the quote delimiters around a literal string value of an input parameter's default value, before applying it in the ROM data set parameter.  This includes esacaping any embedded quote characters.

The reverse conversion is performed when adapting a ROM data set input parameter's default value back to an oda.design definition.

Tests Description:
JUnit tested

Notes to Build Team:
None.

Notes to Developers:
None.

Notes to QA:
None.

Notes to Documentation:
None.

Files Edited:
CVS:/cvsroot/birt/source/
org.eclipse.birt.report.model.adapter.oda/
        src/org/eclipse/birt/report/model/adapter/oda/
                DataSetParameterAdapter.java
        test/org/eclipse/birt/report/model/adapter/oda/
                AllTests.java
        test/org/eclipse/birt/report/model/adapter/oda/api/golden/
                OdaDataSetParseTest_golden.xml

Files Added:
org.eclipse.birt.report.model.adapter.oda/
        test/org/eclipse/birt/report/model/adapter/oda/
                ParameterValueUtilTest.java

Files Deleted:
None.


Back to the top