[birt-dev] CheckIn bugzilla 130494 --- remove choicetypes in 'verticalAl

["Xingjie He" <xhe@xxxxxxxxxxx>]

Summary:

Clean choicetypes in 'verticalAlign' choiceset except 'top' , 'bottom' , 'middle' ; Add the reference to the editor

 

Bugzilla Bug (s) Resolved: 130494 , 140159

 

Description:

1、            In ErrorDetail.java, add the reference to the editor and more setter methods.

2、            In Rom.ref , comment the invalid value of ‘verticalAlign’ choiceset, only left ‘top,’bottom’,’middle’ that Engine can deal with.

3、            In PropertyState.java , when meet ‘verticalAlign’ choiceset, jump to CompatibleVerticalAlignState.java.

4、            In CompatibleVerticalAlignState.java , when meet invalid value of ‘verticalAlign’ choiceset, don’t set value to property list of element.

5、            Add unit test.

 

Tests Description : Junit test.

 

Files Edited:

 

"/org.eclipse.birt.report.model/test/org/eclipse/birt/report/model/parser/ChoiceParseTest.java”

"/org.eclipse.birt.report.model/test/org/eclipse/birt/report/model/parser/input/ ChoiceParseTest.xml”

"/org.eclipse.birt.report.model/test/org/eclipse/birt/report/model/parser/golden/ ChoiceParseTest_golden.xml”

"/org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/elements/Rom.ref”

"/org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/api/elements/ DesignChoiceConstants.java”

"/org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/api/ ErrorDetail.java”

"/org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/parser/PropertyState.java”

 

Files Added:

 

"/org.eclipse.birt.report.model/src/org/eclipse/birt/report/model/parser/CompatibleVerticalAlignState.java”

 

Notes to Build Team:

 

Notes to Developers:

 

Notes to QA:

 

 

Mark He XingJie

Actuate Software Shanghai Center

Tel: (86)21-58826388

Fax: (86)21-58826002

Email: xhe@xxxxxxxxxxx