- Summary:
Separate property searching strategy from element class in order to make DesignElement
less fat.
-
Bugzilla Bug (s) Resolved:
N/A
-
Description:
With more and more features adding to BIRT, the relationship between elements come
to be more and more complicated, such as parent and child, container and content,
virtual parent and virtual child and so on. Also we need take care of CSS rules.
All these lead to complicated property searching route which is implemented in DesignElement
class. DesignElement looks overstaffed nowadays. So we consider separate the property
searching strategy from DesignElement to PropertySearchStrategy.
- Tests Description :
-
Files Edited:
src/org/eclipse/birt/report/model/elements/ExtendedItem.java;
src/org/eclipse/birt/report/model/elements/GroupElement.java;
src/org/eclipse/birt/report/model/elements/Cell.java;
src/org/eclipse/birt/report/model/elements/GridItem.java;
src/org/eclipse/birt/report/model/elements/TableItem.java;
src/org/eclipse/birt/report/model/util/ModelUtil.java;
src/org/eclipse/birt/report/model/command/ElementLocalizeRecord.java;
src/org/eclipse/birt/report/model/command/ExtendsCommand.java;
src/org/eclipse/birt/report/model/core/StyledElement.java;
src/org/eclipse/birt/report/model/core/DesignElement.java;
src/org/eclipse/birt/report/model/api/ComputedValueHandler.java;
-
Files
Added:
src/org/eclipse/birt/report/model/elements/strategy/CellPropSearchStrategy.java;
src/org/eclipse/birt/report/model/elements/strategy/GroupElementPropSearchStrategy.java;
src/org/eclipse/birt/report/model/elements/strategy/ExtendedItemPropSearchStrategy.java;
src/org/eclipse/birt/report/model/core/PropertySearchStrategy.java;
-
Notes to Build Team:
-
Notes to Developers:
-
Notes to QA:
-
Notes to Documentation:
Best regards,
Jane Liu
Actuate Corporation - Shanghai R&D Center
( : (86)21-58826388