Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[andmore-dev] Bug 525493 - Projects containing aar libraries currently fail with robolectric 3.2.1
I have hit an important change to the build tools which needs to be addressed. The Dex tool main class has changed with version 26 from being totally static to just having a static main method.
This means the DexWrapper class is no longer needed and in fact throws an NPE when dexing with version 26 dx.jar.
 
How should I proceed? To jettison DexWrapper forces everyone to use build tools version 26 and above.To leave it in adds unwelcome complexity to Andmore.
 
Andrew

From: Andrew Bowley [mailto:andrewbowley@xxxxxxxxxxx]
Sent: Tuesday, 17 October 2017 9:47 AM
To: 'andmore developer discussions'
Subject: RE: [andmore-dev] Bug 525493 - Projects containing aar libraries currently fail with robolectric 3.2.1

Dave
 
I have pressed on, patching the code to avoid compilation errors, and one issue needs to be resolved from this activity.
 
There is a class named DeviceMenuListener in "adt" package org.eclipse.andmore.internal.editors.layout.configuration which has the following logic:
 
"Group the devices by manufacturer, then put them in the menu. If we don't have anything but Nexus devices, group them together rather than make many manufacturer submenus."
 
I had to comment out the Nexus code as it references objects in an sdk-common helper class which have been removed. Maybe a bug report needs to be raised so the design can be reviewed.
 
I am now at the stage of having set up a test environment to proove the PR. I am hoping there are no big surprizes so I can submit the PR shortly.
 
Andrew
 

From: andmore-dev-bounces@xxxxxxxxxxx [mailto:andmore-dev-bounces@xxxxxxxxxxx] On Behalf Of Carver, David
Sent: Monday, 16 October 2017 11:42 PM
To: andmore-dev@xxxxxxxxxxx
Subject: Re: [andmore-dev] Bug 525493 - Projects containing aar libraries currently fail with robolectric 3.2.1

Andrew, thanks.   Can you put a pull request together that contains all the fixes, and I'll try to get it going through the simulataneous review process.  This will allow us to merge the change, while allowing the IP team to do their review.

In this case, it would be better to have one commit with all the changes, so it would be easier to back out if we need to for any reason.   If you follow the format of the other commit messages, the PR will automatically be linked back to bugzilla.

Thanks for the all the effort on this.

Dave



On 10/15/2017 4:50 PM, Andrew Bowley wrote:
Please find attached file containing information on dependency jars for the CQ process.
 
The bug fix requires Andriod SDK builder-2.3.3.jar which declares 34 dependencies. These include 7 other SDK artifacts which I indicate are not expected to be deployed at this time.
 
Andrew
 


_______________________________________________
andmore-dev mailing list
andmore-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/andmore-dev

Back to the top