Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [wtp-releng] Smoke Test Request for WTP 1.5.4 M and WTP 2.0 I

Title: Message
yep, I will gladly avoid the clown nose for these :) 
 
The build flag change appears to only be impacting total execution time (for a subset of the suites) and the actual test failures look like distinct issues; thanks for doing for a more careful look, David.
 
-Rob
-----Original Message-----
From: wtp-releng-bounces@xxxxxxxxxxx [mailto:wtp-releng-bounces@xxxxxxxxxxx] On Behalf Of David M Williams
Sent: Thursday, March 22, 2007 11:02 AM
To: Webtools releng discussion list
Subject: RE: [wtp-releng] Smoke Test Request for WTP 1.5.4 M and WTP 2.0 I


Rob, as much as we'd all like to blame these breaks on you and see you with the red clown nose  :)

I'm not convinced yet you deserve it,

The "suite time" is now 30 minutes (up from 10 minutes we tried last week).
I don't think JSPCoreTestSuite uses common.tests.OperationTestCase,
org.eclipse.jst.ws.tests.unittest.AllWSJUnitTests has been having problems for a while.

org.eclipse.jst.servlet.tests.bvt.AutomatedBVT has been zero attempted since forever (well, last month at least)
and the j2ee.tests failure doesn't appear to be related to timeouts.

So, I recommend you revert, and we'll see what happens ... but if you make things worse by reverting,
_then_ we'll give you the clown nose! :)









"Rob Frost" <rfrost@xxxxxxx>
Sent by: wtp-releng-bounces@xxxxxxxxxxx

03/22/2007 10:13 AM

Please respond to
Webtools releng discussion list <wtp-releng@xxxxxxxxxxx>

To
"Webtools releng discussion list" <wtp-releng@xxxxxxxxxxx>
cc
Subject
RE: [wtp-releng] Smoke Test Request for WTP 1.5.4 M and WTP 2.0 I





I had "fixed" an error in org.eclipse.wst.common.tests.OperationTestCase where it was ignoring the "waitForBuildToComplete" flag (and modified the runAndVerify() and runDataModel() methods to correctly wait for the build to complete if that flag were set to true); I added some unit tests that actually needed to ensure the the build was completed.
 
Looks like the increase in total execution time that results from actually waiting for the build to complete has now caused some unit test suits to time out.
 
A couple of options:
 
-Leave the "fix" in (i.e. that code will behave according to stated API and users of the class will either need to change the value of the flag, if they do not in fact need to wait until the build has completed, or adjust execution time expectations accordingly).
 
-Revert back to the incorrect behavior (i.e. ignore the "waitForBuildToComplete" flag).
 
Unless there is a need to quickly drop execution time to avoid timeouts, I think the first option is probably the best course but I'm happy to revert it back to the old behavior.
 
-Rob
-----Original Message-----
From:
wtp-releng-bounces@xxxxxxxxxxx [mailto:wtp-releng-bounces@xxxxxxxxxxx] On Behalf Of John Lanuti
Sent:
Thursday, March 22, 2007 9:28 AM
To:
wtp-releng@xxxxxxxxxxx
Subject:
[wtp-releng] Smoke Test Request for WTP 1.5.4 M and WTP 2.0 I


Please smoke test the WTP 1.5.4 build if your team has made any changes:


http://download.eclipse.org/webtools/committers/drops/R1.5/M-1.5.4-200703220230/


All teams please smoke test the latest WTP 2.0 M6 I Build:


http://download.eclipse.org/webtools/committers/drops/R2.0/I-I200703220755-200703220755/


There are some issues with the JUnits, but a lot of progress has been made.  Please continue investigating the following issues:


org.eclipse.jst.j2ee.tests.bvt.AutomatedBVT 1 Error
org.eclipse.jst.jsp.core.tests.JSPCoreTestSuite DNF (Did not finish)
org.eclipse.jst.ws.tests.unittest.AllWSJUnitTests DNF (Did not finish)

org.eclipse.jst.servlet.tests.bvt.AutomatedBVT 0 Tests Attempted

If any of these issues are real problems with the code, and not the tests, and will prevent smoke tests, please reply to this list.


Thanks,


John Lanuti
IBM Web Tools Platform Technical Lead, IBM Rational
IBM Software Lab - Research Triangle Park, NC
jlanuti@xxxxxxxxxx
t/l 441-7861

_______________________________________________________________________
Notice:  This email message, together with any attachments, may contain
information  of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated
entities,  that may be confidential,  proprietary,  copyrighted  and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.
_______________________________________________
wtp-releng mailing list
wtp-releng@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-releng


Back to the top