Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-releng] More on JUnit's policy and principles


Hi David,

I do not object to declaring an I-build this week without this problem fixed. I agree that we do not need to wait for the schema to be restored to declare the RC. There is a simple work around using the XML catalog that can be used where necessary.

Unfortunately I was not on today's status call and did not get the whole story. Thank you for bringing me up to speed. I'd like to retract my statement about disapproving the removal of this test. With the bug open so we won't forget about this issue I'm happy to proceed as you suggest with commenting out the test until we have a fix. I certainly wouldn't want to be a part of facilitating the bad practice of ignoring failing JUnits. :)

Thanks again,

Lawrence Mandel

Software Developer
IBM Rational Software
Phone: 905 - 413 - 3814   Fax: 905 - 413 - 4920
lmandel@xxxxxxxxxx



David M Williams <david_williams@xxxxxxxxxx>
Sent by: wtp-releng-bounces@xxxxxxxxxxx

01/25/2007 06:32 PM

Please respond to
Webtools releng discussion list <wtp-releng@xxxxxxxxxxx>

To
Webtools releng discussion list <wtp-releng@xxxxxxxxxxx>
cc
Subject
[wtp-releng] More on JUnit's policy and principles






>  I've got to voice my disapproval of commenting out this failing test.


Lawrence, perhaps you mean you object to us declaring a  build this week if this problem is not fixed? If so, please let us know.


But otherwise, the failing JUnit's are first and foremost for committers to know there's a problem. Once known, a bug is open,
folks begin to work on it with a priority measured right along with every other bug, but if it can not be fixed right away, there is no further
advantage to displaying the failing JUnit's. And, it's my belief it's actually a bad practice to leave "known
failing tests" in the suite, since it teaches everyone to ignore nonzero numbers, since they are often nonzero.  


I requested this action the status call, so you might not have known the whole story behind the brief summary,
if you were not on the status call.


I definitely agree with you this problem is serious and needs to be fixed. My own opinion is we do not need to wait until the "ibm.com" site is
fixed for us to declare this RC, but if you and other committers think we should wait for ibm.com to fix their site, then I'd want to know that, and
the details of why.


Thanks
_______________________________________________
wtp-releng mailing list
wtp-releng@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-releng


Back to the top