Hi Rochelle,
This is somewhat of a limitation. The user could just want to update the
existing host name (e.g. switching from 'localhost' to their local host
name), but this leaves us open to typing errors or entering a completely
different host name. We can do a better job of providing validation
errors (please open bugs for any gaps you see), but ultimately there is
nothing stopping them from saving at any time, or cases unrelated to the
editor like using an IP address that becomes invalid when they move to
another network. We should continually improve validation and close edge
cases we find, but ultimately both the framework and server adapters
need to be robust enough (both in code quality and usability) to handle
invalid host names appropriately.
Thanks,
Tim deBoer
deboer@xxxxxxxxxx
From: raccah@xxxxxxxxxxxx
To: "General discussion of project-wide or architectural issues."
<wtp-dev@xxxxxxxxxxx>
Date: 09/26/2008 06:48 PM
Subject: Re: [wtp-dev] questions on local/remote support for generic
server adapters
------------------------------------------------------------------------
Hi Tim,
Just getting back to this. I now see what you mean about the wizard
filtering out servers to start. My question is, once you've set up a
server which is a local host, you can double click it and edit the host
name in the editor window. Why does that allow to type in something for
which SocketUtil.isLocalhost() returns false?
Thanks,
Rochelle
Tim deBoer wrote:
>
> Hi Rochelle,
>
> I'm not sure I understand your question. The field is always editable,
> but the wizard already uses SocketUtil.isLocalhost() to determine if you
> are typing a local hostname. If you type anything that is a remote host
> or IP, it filters out server adapters that only support local servers.
>
> Thanks,
> Tim deBoer
> deboer@xxxxxxxxxx
>
>
> From: raccah@xxxxxxxxxxxx
> To: "General discussion of project-wide or
architectural issues."
> <wtp-dev@xxxxxxxxxxx>
> Date: 08/01/2008 04:42 PM
> Subject: Re: [wtp-dev] questions on local/remote
support for generic
> server adapters
>
>
> ------------------------------------------------------------------------
>
>
>
> Hi Max,
>
> Thanks for your response. If I understand it correctly, it sounds like
> you want to keep the ability to enter something other than localhost in
> that field, but that something is another name for the local host. Is
> that accurate? If so, your pointer to the isRemote and isLocal code was
> helpful, but leads me to ask my next question:
>
> There is a method isLocalHost in
> org.eclipse.wst.server.core.util.SocketUtil which seems like it should
> be used for this exact purpose. It seems like the field could remain
> editable, but that the framework should enforce isLocalHost returns true
> for any changes.
>
> Do you agree? If so, I will file it. If not, please tell me what
> usecase I have missed.
>
> Thanks!
> Rochelle
>
> Max Rydahl Andersen wrote:
> > On Mon, 21 Jul 2008 23:38:53 +0200, <raccah@xxxxxxxxxxxx> wrote:
> >
> >> Can you give more detail? Are you saying it makes sense to allow
> >> editing the hostname because even though a server only supports
local,
> >> there are some remote actions you can do on it? If so, what are
they?
> >
> > open a browser and do http://www.whatevermyhostis.com:8080/ is a
> common remote action is it not?
> >
> >> And, if you have any info as to what setting the remote host support
> >> flag to true is supposed to provide, I would appreciate it.
> >
> > The only remote thing I remember without looking at code is that
> automatic deployment works at a different interval than local servers. I
> would do a find references on the isRemote or is isLocal in eclipse and
> see what it reveals.
> >
> > -max
> >
> >> Thanks,
> >> Rochelle
> >>
> >> Max Rydahl Andersen wrote:
> >>>> Also, why is the Hostname shown as an editable field in the
> general info
> >>>> of the OverviewEditorPart if supportsRemoteHosts is false?
Shouldn't
> >>>> this be non-editable if it is shown at all?
> >>> just because it is local in context of
> deployment/debugging/launching then
> >>> a hostname is relevant for connecting externally. We use the
> hostname as a
> >>> parameter for which host/ip the server should bind to.
> >>>
> >>> /max
> >>> _______________________________________________
> >>> wtp-dev mailing list
> >>> wtp-dev@xxxxxxxxxxx
> >>> https://dev.eclipse.org/mailman/listinfo/wtp-dev
> >> _______________________________________________
> >> wtp-dev mailing list
> >> wtp-dev@xxxxxxxxxxx
> >> https://dev.eclipse.org/mailman/listinfo/wtp-dev
> >>
> >
> >
> >
> _______________________________________________
> wtp-dev mailing list
> wtp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> wtp-dev mailing list
> wtp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/wtp-dev
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev
------------------------------------------------------------------------
_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev