[wtp-dev] changes to org.eclipse.wst.sse.ui.preferences.CommonEditorPref

[David M Williams <david_williams@xxxxxxxxxx>]

Thanks to Amy for not only cleaning up this code,
but also providing this nice description, 
which I almost forgot to post as I committed her patches.
I dont't think this directly 
effects others in WTP stack, but might co-developers
which are building add-ons or extensions 
to WTP. Comments welcome. These changes have been
committed to head, and will be released 
for next I-build. 
Please see https://bugs.eclipse.org/bugs/show_bug.cgi?id=87589
for more details

= = = = = = 

The following preference keys have been removed from 
CommonEditorPreferenceNames because they were already deprecated.  In
most 
cases, there were removed because the base now provides those preference
keys, 
so you should look for your preference keys in the following classes:
org.eclipse.ui.texteditor.AbstractDecoratedTextEditorPreferenceConstants
org.eclipse.ui.texteditor.MarkerAnnotationPreferences

Otherwise, look in the previous deprecation javadoc for information on
why 
they were being removed and what to do.
BOOKMARK_INDICATION
BOOKMARK_INDICATION_COLOR
BOOKMARK_INDICATION_IN_OVERVIEW_RULER
BROWSER_LIKE_LINKS
BROWSER_LIKE_LINKS_KEY_MODIFIER
CONTENT_ASSIST_SUPPORTED
DOT
EDITOR_ANNOTATION_ROLL_OVER
EDITOR_SHOW_TEXT_HOVER_AFFORDANCE
ERROR_INDICATION
ERROR_INDICATION_COLOR
ERROR_INDICATION_IN_OVERVIEW_RULER
LINK_COLOR
LT
LT_PERCENT
SEARCH_RESULT_INDICATION
SEARCH_RESULT_INDICATION_COLOR
SEARCH_RESULT_INDICATION_IN_OVERVIEW_RULER
SHOW_QUICK_FIXABLES
TASK_INDICATION
TASK_INDICATION_COLOR
TASK_INDICATION_IN_OVERVIEW_RULER
UNKNOWN_INDICATION
UNKNOWN_INDICATION_COLOR
UNKNOWN_INDICATION_IN_OVERVIEW_RULER
WARNING_INDICATION
WARNING_INDICATION_COLOR
WARNING_INDICATION_IN_OVERVIEW_RULER
EMBEDDED_CONTENT_TYPE_PREFERENCES

The following preference keys have been removed from 
CommonEditorPreferenceNames because they are not really StructuredTextEditor
preference keys, rather they are preference keys that should be supplied
by 
each content type.  You can look in the individual content type plugins
to see 
if the preference keys are made public there.
AUTO_PROPOSE
AUTO_PROPOSE_CODE
EDITOR_USE_INFERRED_GRAMMAR
TEMPLATES_KEY


The following preference keys have been removed from 
CommonEditorPreferenceNames because they should only be used internally
by 
StructuredTextEditor.
MATCHING_BRACKETS
MATCHING_BRACKETS_COLOR
EDITOR_TEXT_HOVER_MODIFIERS
READ_ONLY_FOREGROUND_SCALE

Misc deleted preference related classes (they were already deprecated,
look in 
previous deprecation javadoc for information on why they were being removed
and what to do)
org.eclipse.wst.sse.ui.preferences.ui.NavigationPreferenceTab  (navigation
preferences are now handled by the base)

org.eclipse.wst.sse.ui.preferences.PreferenceKeyGenerator (content type
preference keys should be stored in the content type's own preference store)

SSEUIPlugin#initializeDefaultEditorPreferences (method is not longer used
because preference initializers are now used)

Please see https://bugs.eclipse.org/bugs/show_bug.cgi?id=87589
for more details