Re: [viatra-dev] Last minute updates to the incremental API

[Ujhelyi Zoltán <ujhelyiz@xxxxxxxxxx>]

Hi,

thanks for the quick feedback.

The minor issues are fixed; about the rule group issue: we had exactly the same codebase twice, making it harder than necessary to do the changes.

On the other hand, I have created descendants of this generic class (BatchTransformationRuleGroup and EventDrivenTransformationRuleGroup), that are not generic and can be used in transformations. I also extended the corresponding change with updating the statements to explicitly require these descendants. In this way, we don’t have to duplicate code, but still have everything working.

Cheers,
Zoli
> On 30 May 2015, at 22:23, David, Istvan <davidi@xxxxxxxxxxxxxx> wrote:
> 
> Hi Zoli,
> 
> In https://git.eclipse.org/r/48974, the TransformationRuleGroup became generic despite the previously intentionally non-generic version ("in case of Xtend the transformation code would be full of type safety warnings"). Won't we encounter warnings in Xtend transformations now?
> 
> https://git.eclipse.org/r/49023 looks good. Added a minor comment, but otherwise okay.
> 
> 
> Thanks for the quick fixes!
> 
> Cheers,
> Istvan
> 
> 
> 2015-05-30 20:10 GMT+02:00 Ujhelyi Zoltán <ujhelyiz@xxxxxxxxxx>:
> Hi all,
> 
> yesterday we had a long discussion with Ákos about the incremental transformation API of VIATRA, and found two missing features that might be very useful for various cases. As both issues seemed easy to implement, I came up with quick solutions - however, as the freeze date is very close, I’d like to have somebody having a look at these changes before something trivially wrong goes into the code base.
> 
> 1. Currently it is not possible to instantiate an incremental transformation rule, where some pattern parameters are bound to concrete values. This can be very helpful in cases where this could reduce the number of activations greatly. This feature is only missing on the VIATRA level; in EVM the required functionality is already present.
> 
> I have opened bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=468828 for this issue, and have a corresponding Gerrit change available in https://git.eclipse.org/r/48974
> 
> 2. It would be also useful to instantiate event driven transformations that runs only on transactions. The EVM-level support is also available by the use of specific SchedulerFactories, but the VIATRA API did not allow to specify such elements on the interface.
> 
> I have opened bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=468829 for this issue, and have a corresponding Gerrit change available in https://git.eclipse.org/r/49023
> 
> ——
> Sadly, both issues required some cleanup on the incremental transformation code, that caused some minor changes in the API. The transformations I have checked out either required no changes (maybe a rebuild was necessary, but thats all), or some very trivial updates.
> 
> Considering the freeze for the project is close, I would like to have some review of these changes before I merge them into master.
> 
> Thanks,
> Zoli
> -- Zoltán Ujhelyi
> https://www.inf.mit.bme.hu/en/members/ujhelyiz
> 
> Fault Tolerant Systems Research Group
> Budapest University of Technology and Economics
> 
> _______________________________________________
> viatra-dev mailing list
> viatra-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/viatra-dev
> 
> _______________________________________________
> viatra-dev mailing list
> viatra-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/viatra-dev