[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [udig-devel] [jira] Issue Comment Edited: (UDIG-1726) Deadlock in Tile.disposeSWTImage()
|
I would appreciate if a PSC member could review this patch and possible commit it to trunk.
With time, I hope to join the uDig Core team. This would make things much easier for my self and my project since bugs that I find can be committed faster, and with less effort from team members, to tags/trunk.
Best Regards,
Kenneth Gulbrandsøy
2010/9/1 Kenneth Gulbrandsøy (JIRA)
<jira@xxxxxxxxxxxx>
[ http://jira.codehaus.org/browse/UDIG-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=233909#action_233909 ]
Kenneth Gulbrandsøy edited comment on UDIG-1726 at 9/1/10 8:54 AM:
-------------------------------------------------------------------
The problem was located in the Tile.getSWTImage() method. The private member swtImage was not synchronized (as it should be to prevent deadlocks). Note that this design is bad. Exposure of this private member makes deadlocks, like the one reported in this issue, possible. I have added a warning in the documentation of Tile.getSWTImage() method. A patch with the fix and the warning is attached.
was (Author: kengu):
The problem was located in the Tile.getSWTImage() method. The private member swtImage was not synchronized (as it should be to prevent deadlocks). Note that this design is bad. Exposure of this private member makes deadlocks, like the one reported in this issue, possible. I have added a warning in the documentation of Tile.getSWTImage() method.
> Deadlock in Tile.disposeSWTImage()
> ----------------------------------
>
> Key: UDIG-1726
> URL: http://jira.codehaus.org/browse/UDIG-1726
> Project: uDIG
> Issue Type: Bug
> Components: application
> Affects Versions: UDIG 1.2.0
> Environment: eclipse=3.6
> java.version=1.6.0_20
> java.vendor=Sun Microsystems Inc.
> BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=nb_NO
> Framework arguments: -product net.refractions.udig.tutorials.rcp.product
> Reporter: Kenneth Gulbrandsøy
> Attachments: net.refractions.udig.tutorials.rcp.bug, UDIG-1726-net.refractions.udig.project.render.tile-01092010.patch
>
>
> To reproduce the deadlock, do the following:
> 1. Run net.refractions.udig.tutorials.rcp
> 2. Open map
> 3. Open map with outline
> 4. Click on the "map view"
> 5. Click on the "map with outline" view
> 6. Continue to toggle between map views (step 4 and 5) until UI freezes
> The deadlock occurs repeatedly both in the SDK and trunk on linux x86_64 (not tested on other operating systems).
> A copy of the stack traces showing where the deadlock occurs is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
