[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [udig-devel] Oracle plugin fail
|
Hi list, again,
I was playing yesterday with the plug-in and it works fine now
effectively (I tried to be exhaustive checking a lot of Oracle tables
with different geometry types).
Problems was started with OracleGeoResource's constructor, where code at
1.2RC3 version was:
###########################################################################
public class OracleGeoResource extends IGeoResource {
String typename = null;
/**
* Construct <code>OracleGeoResource</code>.
*
* @param parent
* @param typename
*/
public OracleGeoResource( OracleServiceImpl parent, String typename ) {
this.typename = typename;
}
public URL getIdentifier() {
try {
return new URL(service.getIdentifier().toString() + "#" +
typename); //$NON-NLS-1$
} catch (MalformedURLException e) {
return service.getIdentifier();
}
}
[...]
###########################################################################
And correct way is (which is the actual version on trunk):
###########################################################################
public class OracleGeoResource extends IGeoResource {
String typename = null;
private ID id;
/**
* Construct <code>OracleGeoResource</code>.
*
* @param parent
* @param typename
*/
public OracleGeoResource( OracleServiceImpl parent, String typename ) {
this.service = parent;
this.typename = typename;
this.id = new ID(service.getID(), typename );
}
@Override
public ID getID() {
return id;
}
@Override
public URL getIdentifier() {
return id.toURL();
}
[...]
###########################################################################
There are some changes on OraclePlugin trunk but I'm not sure if them
are related with my initial problem. (Attached the versions for commodity).
It's been working since last svn update on past monday, but I don't
know who was the committer
(if you are reading this, receive my deeply grateful).
Jody Garnett escribió:
> You indicated on IRC that things were working now?
> What was the fix so I can update the codebase :)
>
> Jody
>
> On 03/06/2010, at 8:31 PM, jcamara@xxxxxx wrote:
>
>
>> Hi again,
>>
>> I'm fighting with Oracle yet, but we can't progress with it.
>>
>> Tried with uDig 1.1.1 and works fine, recovering all tables perfectly.
>> With 1.2RC3_SDK, results as previous message.
>>
>> Now, I've just try with svn-trunk version of:
>> net.refractions.udig.catalog.oracle Plugin, which seems to connect fine,
>> but can't get tables properly. Restore all tables items... but with same
>> name. If try add to map, it's results with a 'new layer' that start
>> crashing uDig.
>>
>> I attach screenshot (ORACLE_Punto_Layer_Type isn't an Oracle
>> layer...it's a wfs layer).
>>
>> Any suggestion about how can I go forward?
>>
>> Very thanks in advance.
>>
>>
>> Jody Garnett escribió:
>>
>>> Sigh; it was a one line fix (now committed). What platform are you on, I could issue a "snapshot" release for you to test against.
>>>
>>> The other thing to do if you are having trouble is we can try using the GeoTools DataStore wizard to connect to oracle. It has a few more options; but is not as fancy.
>>>
>>> Jody
>>>
>>> On 25/05/2010, at 7:34 PM, jcamara@xxxxxx wrote:
>>> [...]
>>>
>>> _______________________________________________
>>> User-friendly Desktop Internet GIS (uDig)
>>> http://udig.refractions.net
>>> http://lists.refractions.net/mailman/listinfo/udig-devel
>>>
>>>
>> --
>> Javier Cámara Pérez
>> Área de Ejecución de Proyectos SIG
>> Subdirección de Sistemas de Información
>> E.P. Desarrollo Agrario y Pesquero
>> Oficina Provincial de Córdoba
>> Avda. Menéndez Pidal s/n
>> 14004 - Córdoba
>> Telf: 50.59.12 / 957.00.59.12 | Skype: jcamaradap
>>
>> <OracleFromTrunk.PNG>_______________________________________________
>> User-friendly Desktop Internet GIS (uDig)
>> http://udig.refractions.net
>> http://lists.refractions.net/mailman/listinfo/udig-devel
>>
>
> _______________________________________________
> User-friendly Desktop Internet GIS (uDig)
> http://udig.refractions.net
> http://lists.refractions.net/mailman/listinfo/udig-devel
>
--
Javier Cámara Pérez
Área de Ejecución de Proyectos SIG
Subdirección de Sistemas de Información
E.P. Desarrollo Agrario y Pesquero
Oficina Provincial de Córdoba
Avda. Menéndez Pidal s/n
14004 - Córdoba
Telf: 50.59.12 / 957.00.59.12 | Skype: jcamaradap
/*
* uDig - User Friendly Desktop Internet GIS client
* http://udig.refractions.net
* (C) 2004, Refractions Research Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation;
* version 2.1 of the License.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
*/
package net.refractions.udig.catalog.internal.oracle;
import java.io.IOException;
import java.net.MalformedURLException;
import java.net.URI;
import java.net.URISyntaxException;
import java.net.URL;
import net.refractions.udig.catalog.CatalogPlugin;
import net.refractions.udig.catalog.IGeoResource;
import net.refractions.udig.catalog.IGeoResourceInfo;
import net.refractions.udig.catalog.IService;
import net.refractions.udig.catalog.oracle.internal.Messages;
import net.refractions.udig.ui.graphics.Glyph;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.IStatus;
import org.geotools.data.FeatureSource;
import org.geotools.data.FeatureStore;
import org.geotools.feature.FeatureIterator;
import org.geotools.geometry.jts.ReferencedEnvelope;
import org.geotools.jdbc.JDBCDataStore;
import org.opengis.feature.simple.SimpleFeature;
import org.opengis.feature.simple.SimpleFeatureType;
import org.opengis.referencing.crs.CoordinateReferenceSystem;
import com.vividsolutions.jts.geom.Envelope;
/**
* Provides ...TODO summary sentence
* <p>
* TODO Description
* </p>
*
* @author David Zwiers, Refractions Research
* @since 0.6
*/
public class OracleGeoResource extends IGeoResource {
String typename = null;
/**
* Construct <code>OracleGeoResource</code>.
*
* @param parent
* @param typename
*/
public OracleGeoResource( OracleServiceImpl parent, String typename ) {
this.typename = typename;
}
OracleServiceImpl getService() {
return (OracleServiceImpl) service;
}
public URL getIdentifier() {
try {
return new URL(service.getIdentifier().toString() + "#" + typename); //$NON-NLS-1$
} catch (MalformedURLException e) {
return service.getIdentifier();
}
}
/*
* @see net.refractions.udig.catalog.IGeoResource#getStatus()
*/
public Status getStatus() {
return service.getStatus();
}
/*
* @see net.refractions.udig.catalog.IGeoResource#getStatusMessage()
*/
public Throwable getMessage() {
return service.getMessage();
}
/*
* Required adaptions: <ul> <li>IGeoResourceInfo.class <li>IService.class </ul>
* @see net.refractions.udig.catalog.IResolve#resolve(java.lang.Class,
* org.eclipse.core.runtime.IProgressMonitor)
*/
public <T> T resolve( Class<T> adaptee, IProgressMonitor monitor ) throws IOException {
if (adaptee == null)
return null;
// if (adaptee.isAssignableFrom(IService.class))
// return adaptee.cast(parent);
if (adaptee.isAssignableFrom(IGeoResourceInfo.class))
return adaptee.cast(createInfo(monitor));
if (adaptee.isAssignableFrom(IGeoResource.class))
return adaptee.cast(this);
if (adaptee.isAssignableFrom(FeatureStore.class)) {
JDBCDataStore dataStore = getService().getDS(monitor);
FeatureSource<SimpleFeatureType, SimpleFeature> fs = dataStore
.getFeatureSource(typename);
if (fs instanceof FeatureStore< ? , ? >){
return adaptee.cast(fs);
}
if (adaptee.isAssignableFrom(FeatureSource.class)) {
dataStore = getService().getDS(monitor);
return adaptee.cast(dataStore.getFeatureSource(typename));
}
}
return super.resolve(adaptee, monitor);
}
/*
* @see net.refractions.udig.catalog.IResolve#canResolve(java.lang.Class)
*/
public <T> boolean canResolve( Class<T> adaptee ) {
if (adaptee == null)
return false;
return (adaptee.isAssignableFrom(IGeoResourceInfo.class)
|| adaptee.isAssignableFrom(FeatureStore.class)
|| adaptee.isAssignableFrom(FeatureSource.class) || adaptee
.isAssignableFrom(IService.class))
|| super.canResolve(adaptee);
}
protected IGeoResourceInfo createInfo( IProgressMonitor monitor ) throws IOException {
if (getStatus() == Status.BROKEN) {
return null; // could not connect
}
getService().rLock.lock();
try {
return new OracleResourceInfo();
} finally {
getService().rLock.unlock();
}
}
class OracleResourceInfo extends IGeoResourceInfo {
private SimpleFeatureType ft = null;
OracleResourceInfo() throws IOException {
JDBCDataStore dataStore = getService().getDS(null);
ft = dataStore.getSchema(typename);
try {
FeatureSource<SimpleFeatureType, SimpleFeature> source = dataStore
.getFeatureSource(typename);
bounds = (ReferencedEnvelope) source.getBounds();
if (bounds == null) {
CoordinateReferenceSystem crs = null;
// GeometryDescriptor defaultGeometry =
// source.getSchema().getGeometryDescriptor();
crs = source.getSchema().getCoordinateReferenceSystem();
bounds = new ReferencedEnvelope(new Envelope(), crs);
FeatureIterator<SimpleFeature> iter = source.getFeatures().features();
try {
while( iter.hasNext() ) {
SimpleFeature element = iter.next();
if (bounds.isNull())
bounds.init(element.getBounds());
else
bounds.include(element.getBounds());
}
} finally {
iter.close();
}
}
// CoordinateReferenceSystem geomcrs = source.getSchema().getCRS();
// if(geomcrs!=null && !geomcrs.equals(CRS.decode("EPSG:4269"))){
// bounds = JTS.transform(bounds,CRS.transform(geomcrs,CRS.decode("EPSG:4269")));
// }else{
// if(geomcrs == null)
// System.err.println("CRS unknown for Shp");
// }
} catch (Exception e) {
CatalogPlugin
.getDefault()
.getLog()
.log(
new org.eclipse.core.runtime.Status(
IStatus.WARNING,
"net.refractions.udig.catalog", 0, Messages.OracleGeoResource_error_layerBounds, e)); //$NON-NLS-1$
bounds = new ReferencedEnvelope(new Envelope(), null);
}
icon = Glyph.icon(ft);
keywords = new String[]{"postgis", //$NON-NLS-1$
ft.getName().getLocalPart(), ft.getName().getNamespaceURI()};
}
public CoordinateReferenceSystem getCRS() {
return ft.getCoordinateReferenceSystem();
}
public String getName() {
return ft.getName().getLocalPart();
}
public URI getSchema() {
try {
return new URI(ft.getName().getNamespaceURI());
} catch (URISyntaxException e) {
return null;
}
}
public String getTitle() {
return ft.getName().getLocalPart();
}
}
}/*
* uDig - User Friendly Desktop Internet GIS client
* http://udig.refractions.net
* (C) 2004, Refractions Research Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation;
* version 2.1 of the License.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
*/
package net.refractions.udig.catalog.internal.oracle;
import java.io.IOException;
import java.net.MalformedURLException;
import java.net.URI;
import java.net.URISyntaxException;
import java.net.URL;
import net.refractions.udig.catalog.CatalogPlugin;
import net.refractions.udig.catalog.ID;
import net.refractions.udig.catalog.IGeoResource;
import net.refractions.udig.catalog.IGeoResourceInfo;
import net.refractions.udig.catalog.IService;
import net.refractions.udig.catalog.oracle.internal.Messages;
import net.refractions.udig.core.jts.ReferencedEnvelopeCache;
import net.refractions.udig.ui.graphics.Glyph;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.IStatus;
import org.geotools.data.FeatureSource;
import org.geotools.data.FeatureStore;
import org.geotools.feature.FeatureIterator;
import org.geotools.geometry.jts.ReferencedEnvelope;
import org.geotools.jdbc.JDBCDataStore;
import org.opengis.feature.simple.SimpleFeature;
import org.opengis.feature.simple.SimpleFeatureType;
import org.opengis.referencing.crs.CoordinateReferenceSystem;
import com.vividsolutions.jts.geom.Envelope;
/**
* OracleGeoResource representing a table or view.
*
* @author David Zwiers, Refractions Research
* @since 0.6
*/
public class OracleGeoResource extends IGeoResource {
String typename = null;
private ID id;
/**
* Construct <code>OracleGeoResource</code>.
*
* @param parent
* @param typename
*/
public OracleGeoResource( OracleServiceImpl parent, String typename ) {
this.service = parent;
this.typename = typename;
this.id = new ID(service.getID(), typename );
}
OracleServiceImpl getService() {
return (OracleServiceImpl) service;
}
@Override
public ID getID() {
return id;
}
@Override
public URL getIdentifier() {
return id.toURL();
}
/*
* @see net.refractions.udig.catalog.IGeoResource#getStatus()
*/
public Status getStatus() {
return service.getStatus();
}
/*
* @see net.refractions.udig.catalog.IGeoResource#getStatusMessage()
*/
public Throwable getMessage() {
return service.getMessage();
}
/*
* Required adaptions: <ul> <li>IGeoResourceInfo.class <li>IService.class </ul>
* @see net.refractions.udig.catalog.IResolve#resolve(java.lang.Class,
* org.eclipse.core.runtime.IProgressMonitor)
*/
public <T> T resolve( Class<T> adaptee, IProgressMonitor monitor ) throws IOException {
if (adaptee == null){
return null;
}
if (adaptee.isAssignableFrom(IGeoResourceInfo.class)){
return adaptee.cast(createInfo(monitor));
}
if (adaptee.isAssignableFrom(IGeoResource.class)){
return adaptee.cast(this);
}
if (adaptee.isAssignableFrom(FeatureStore.class)) {
JDBCDataStore dataStore = getService().getDS(monitor);
FeatureSource<SimpleFeatureType, SimpleFeature> fs = dataStore
.getFeatureSource(typename);
if (fs instanceof FeatureStore< ? , ? >){
return adaptee.cast(fs);
}
if (adaptee.isAssignableFrom(FeatureSource.class)) {
dataStore = getService().getDS(monitor);
return adaptee.cast(dataStore.getFeatureSource(typename));
}
}
return super.resolve(adaptee, monitor);
}
/*
* @see net.refractions.udig.catalog.IResolve#canResolve(java.lang.Class)
*/
public <T> boolean canResolve( Class<T> adaptee ) {
if (adaptee == null)
return false;
return (adaptee.isAssignableFrom(IGeoResourceInfo.class)
|| adaptee.isAssignableFrom(FeatureStore.class)
|| adaptee.isAssignableFrom(FeatureSource.class) || adaptee
.isAssignableFrom(IService.class))
|| super.canResolve(adaptee);
}
@Override
public OracleResourceInfo getInfo( IProgressMonitor monitor ) throws IOException {
return (OracleResourceInfo) super.getInfo(monitor);
}
protected OracleResourceInfo createInfo( IProgressMonitor monitor ) throws IOException {
if (getStatus() == Status.BROKEN) {
return null; // could not connect
}
getService().rLock.lock();
try {
return new OracleResourceInfo();
} finally {
getService().rLock.unlock();
}
}
class OracleResourceInfo extends IGeoResourceInfo {
private SimpleFeatureType ft = null;
OracleResourceInfo() throws IOException {
JDBCDataStore dataStore = getService().getDS(null);
ft = dataStore.getSchema(typename); // this may be broken in geotools?
this.title = typename;
try {
FeatureSource<SimpleFeatureType, SimpleFeature> source = dataStore
.getFeatureSource(typename);
ft = source.getSchema();
bounds = (ReferencedEnvelope) source.getBounds();
if (bounds == null) {
CoordinateReferenceSystem crs = null;
// GeometryDescriptor defaultGeometry =
// source.getSchema().getGeometryDescriptor();
crs = source.getSchema().getCoordinateReferenceSystem();
this.bounds = ReferencedEnvelopeCache.getReferencedEnvelope(info.getCRS());
/*
// no full table scan for you!
bounds = new ReferencedEnvelope(new Envelope(), crs);
FeatureIterator<SimpleFeature> iter = source.getFeatures().features();
try {
while( iter.hasNext() ) {
SimpleFeature element = iter.next();
if (bounds.isNull())
bounds.init(element.getBounds());
else
bounds.include(element.getBounds());
}
} finally {
iter.close();
}
*/
}
// CoordinateReferenceSystem geomcrs = source.getSchema().getCRS();
// if(geomcrs!=null && !geomcrs.equals(CRS.decode("EPSG:4269"))){
// bounds = JTS.transform(bounds,CRS.transform(geomcrs,CRS.decode("EPSG:4269")));
// }else{
// if(geomcrs == null)
// System.err.println("CRS unknown for Shp");
// }
} catch (Exception e) {
CatalogPlugin
.getDefault()
.getLog()
.log(
new org.eclipse.core.runtime.Status(
IStatus.WARNING,
"net.refractions.udig.catalog", 0, Messages.OracleGeoResource_error_layerBounds, e)); //$NON-NLS-1$
bounds = new ReferencedEnvelope(new Envelope(), null);
}
icon = Glyph.icon(ft);
keywords = new String[]{"postgis", //$NON-NLS-1$
ft.getName().getLocalPart(), ft.getName().getNamespaceURI()};
}
public CoordinateReferenceSystem getCRS() {
return ft.getCoordinateReferenceSystem();
}
public String getName() {
return ft.getName().getLocalPart();
}
public URI getSchema() {
try {
return new URI(ft.getName().getNamespaceURI());
} catch (URISyntaxException e) {
return null;
}
}
public String getTitle() {
return ft.getName().getLocalPart();
}
}
}
