Re: [udig-devel] patch to suppress "all on" WMS layers

[Paul Ramsey <pramsey@xxxxxxxxxxxxxxx>]

Here's an easy policy: if it's a small thing and localized, port it. If 
it is a larger thing, do not. Small enhancements and bug fixes on 1.0. 
Large enhancements and new features on 1.1

Richard Gould wrote:

> I didn't - Do we have a policy on what should be ported to 1.0.x? This 
> isn't really a bug fix, so much as an enhancement.
>
> Richard
>
> Jesse Eichar wrote:
>
> > Richard,  Did you apply it to the 1.0.x branch as well?  should it be? 
> > Jesse
> >
> > On Mon, 2005-27-06 at 11:08 -0700, Richard Gould wrote:
> >
> > > Thanks Carl, I have added the patch to uDig/trunk. In the future, I 
> > > might add this behaviour as a toggle in the preferences, as some 
> > > people might like it. But a tree structure would be ideal.
> > >
> > > Richard
> > >
> > > Carl Anderson wrote:
> > >
> > > > This is the way Paul suggested, suppress the "all on" layer.  I 
> > > > would prefer to symbolize layers by type, using either a tree view, 
> > > > or by color, but that will have to wait.
> > > >
> > > >
> > > > ------------------------------------------------------------------------ 
> > > >
> > > >
> > > > diff -ur --exclude=.svn --exclude=.classpath 
> > > > udig-master/trunk/plugins/net.refractions.udig.catalog.wms/src/net/refractions/udig/catalog/internal/wms/WMSServiceImpl.java 
> > > > udig/trunk/plugins/net.refractions.udig.catalog.wms/src/net/refractions/udig/catalog/internal/wms/WMSServiceImpl.java 
> > > >
> > > > --- 
> > > > udig-master/trunk/plugins/net.refractions.udig.catalog.wms/src/net/refractions/udig/catalog/internal/wms/WMSServiceImpl.java    
> > > > 2005-06-02 20:02:46.000000000 -0400
> > > > +++ 
> > > > udig/trunk/plugins/net.refractions.udig.catalog.wms/src/net/refractions/udig/catalog/internal/wms/WMSServiceImpl.java    
> > > > 2005-06-25 12:04:03.000000000 -0400
> > > > @@ -213,8 +213,13 @@
> > > >                      */
> > > >                     if (layers != null) {
> > > >                         for( int i = 0; i < layers.length; i++ ) {
> > > > -                            Layer layer = layers[i];
> > > > -                            members.add(new 
> > > > WMSGeoResourceImpl(this, layer));
> > > > +                            /* suppress layers that have children
> > > > +                             * should add hasChildren() to geotools?
> > > > +                             */
> > > > +                            if( layers[i].getChildren().length == 0 
> > > > ) {
> > > > +                              Layer layer = layers[i];
> > > > +                              members.add(new 
> > > > WMSGeoResourceImpl(this, layer));
> > > > +                            }
> > > >                         }
> > > >                     }
> > > >                 }
> > > >
> > > >
> > > > ------------------------------------------------------------------------ 
> > > >
> > > >
> > > > _______________________________________________
> > > > User-friendly Desktop Internet GIS (uDig)
> > > > http://udig.refractions.net
> > > > http://lists.refractions.net/mailman/listinfo/udig-devel
> > >
> > >
> > > _______________________________________________
> > > User-friendly Desktop Internet GIS (uDig)
> > > http://udig.refractions.net
> > > http://lists.refractions.net/mailman/listinfo/udig-devel
> >
> >
> >
> > _______________________________________________
> > User-friendly Desktop Internet GIS (uDig)
> > http://udig.refractions.net
> > http://lists.refractions.net/mailman/listinfo/udig-devel
>
>
> _______________________________________________
> User-friendly Desktop Internet GIS (uDig)
> http://udig.refractions.net
> http://lists.refractions.net/mailman/listinfo/udig-devel