Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[udig-devel] All you need to know about victoria

Good job on the labeling Jesse. Great persistence with the style stuff Justin.

I have all the events working through the style system, everything is pretty much displaying as it should. - StyleView listens to workbench selection, and connects up with the current selection when it first starts up
- StyleView listens to layer events
- StyleLayer (a LayerDecorator) overrides style() to return a Blackboard that delegates to a clone of the original blackboard, while issue LayerEvents for each change

We need to tighten down the life cycle for SLDConfigurator and its SLDEditorPart extensions ... by tighten down I mean document.

Here is what I can tell with respect to SLDEditorPart life cycle:
1) construct
2) set label, layer, etc from the extension point
4) init
5) createControl( Component page ); // page is to be used by editor for its content 6) initEditor( part ); // not quite sure why this *must* be called, seems to provide default values if a symbolizer is not actually present
7) part.reset();
8) editorBook.setData( part ); // seems to just be lazy programming, the value is only looked at to save a walk though the data structure
9) editorBook.showPage( part.getPage() );
10) part.getPage().setVisiable( true ); // even though editorBook is supposed to do this?

When ever I don't follow the above something goes wrong.

Jody
BTW: I don't see any evidence of dispose being called directly, we may need to check for resource leaks.

GIF image


Back to the top