Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [udig-devel] Printing API

David Zwiers wrote:

Richard,

Just looked over your printing api. I included most of my comments in
the code with TODO tags. Here are some higher level questions, perhaps
to be answered in a package.html file? It looks quite good.

- Should Box and Connection have circular dependencies?
- Most objects are mutable. Is this intended, and does the framework
support this?
- Perhaps remove the @generated, @model tags from emf generation, as
this is intended to be a stable api now.
Sounds good guys,

I would also ask that listeners be created (so client code is not exposed to EMF adapters directly).

Thanks for the review David,
Jody


Back to the top