On 03/05/2013 05:10 PM, Igor Fedorenko
wrote:
Just
to clarify, jgit timestamp for a dirty working tree does not make
sense because it is impossible to know if the changes will be
committed
or not. So the patch should fail the build if the working tree is
dirty.
The same applies to staged commits, btw.
If you want to test your changes before you commit, you need to
switch
to default timestamp provider... or maybe add configuration
parameter to
jgit provider to use current time.
Having to choose manually on whether to use commit timestamp or
something else will be for sure a cause of errors.
Maybe it would be possible to make something that provides a more
general stategy to the BuildQualifierMojo? For example, we could
think of a strategy that would use the commit timestamp when working
copy is clean, but that would use <commitTimestamp>-DIRTY when
something was changed locally.
Also, it would be interesting to have the tycho-p2-plugin able to
compare a bundle with a baseline ignoring the qualifier.
That would allow to just not care about the qualifier, and if
everything else is the same (classes, MANIFEST...) we replace the
new one with the previous one.
For this, the use-case is not "Reproducible Versions Qualifier" but
"Avoid providing always new builds of the same thing".
WDYT?
|