Re: [tycho-dev] first org.eclipse.tycho commit

[Igor Fedorenko <igor@xxxxxxxxxxxxxx>]

maven-checkstyle-plugin does not seem to have predefined rule-set for
Eclipse style [1]. Does anyone known if it's available from somewhere
else? If not, maven style will be easier to implement and maintain.


[1] http://maven.apache.org/plugins/maven-checkstyle-plugin/

--
Regards,
Igor

On 11-04-12 04:11 AM, Sievers, Jan wrote:
> > Now is the tough question -- what code formatter style should we use for
> > tycho? Maven or Eclipse?
>
> +1 for cleaning this up now and making sure we don't have regressions for the future.
>
> I'm fine with any of the formatter styles as long as it's consistent.
>
> I have a minor bias towards the eclipse style for the simple reason that I don't have to
> bother importing the Maven formatter style into my IDE workspace since the eclipse style is preconfigured.
>
> Regards,
> Jan
>
> -----Original Message-----
> From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
> Sent: Montag, 11. April 2011 19:16
> To: tycho-dev@xxxxxxxxxxx
> Subject: Re: [tycho-dev] first org.eclipse.tycho commit
>
> Another thing I would like to do *after* headers and renames, is to
> apply consistent code format for all tycho sources and even try to
> enforce it with checkstyle rules.
>
> I was reluctant to do this before because this change would make
> git-blame virtually useless. But since we are not moving commit history
> to git.eclipse.org, I think this is a good opportunity to cleanup code
> style.
>
> Now is the tough question -- what code formatter style should we use for
> tycho? Maven or Eclipse?
>
> --
> Regards,
> Igor
>
> On 11-04-11 12:09 PM, Igor Fedorenko wrote:
> > I meant to rename *after* you commit your header changes. Sorry for the
> > confusion.
> >
> > --
> > Regards,
> > Igor
> >
> > On 11-04-11 12:06 PM, Sievers, Jan wrote:
> > > as long as we don't spend the whole week renaming, I'm fine if you
> > > want to do some more renamings while we are at it.
> > > Just make sure you tell me when you're done as I want to apply the
> > > file headers before end of this week.
> > >
> > > Regards,
> > > Jan
> > >
> > > -----Original Message-----
> > > From: tycho-dev-bounces@xxxxxxxxxxx
> > > [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Oberlies, Tobias
> > > Sent: Montag, 11. April 2011 17:31
> > > To: Tycho developers list
> > > Subject: Re: [tycho-dev] first org.eclipse.tycho commit
> > >
> > > +1
> > >
> > > I also had some more renames in mind, now that we are renaming
> > > everything anyway: I'd like to rename the bundle org.sonatype.tycho.p2
> > > (and ~.impl and ~.impl.test) to org.sonatype.tycho.p2.resolver. Any
> > > objections?
> > >
> > > Go ahead first though (I'll be off for today soon).
> > >
> > > Regards
> > > Tobias
> > >
> > >
> > > > -----Original Message-----
> > > > From: tycho-dev-bounces@xxxxxxxxxxx
> > > > [mailto:tycho-dev-bounces@xxxxxxxxxxx]
> > > > On Behalf Of Igor Fedorenko
> > > > Sent: 11 April 2011 17:02
> > > > To: tycho-dev@xxxxxxxxxxx
> > > > Subject: Re: [tycho-dev] first org.eclipse.tycho commit
> > > >
> > > > Any objections I rename ``tycho-osgi-components'' to ``tycho-core'' and
> > > > use ``org.eclipse.tycho.core.*'' package names?
> > > >
> > > > --
> > > > Regards,
> > > > Igor
> > > >
> > > > On 11-04-11 09:28 AM, Sievers, Jan wrote:
> > > > > the package rename is done [1].
> > > > > All ITs are passing.
> > > > >
> > > > > @Igor can you reactivate tycho CI build jobs [2] ?
> > > > >
> > > > > Up next is adding the file headers.
> > > > >
> > > > > Regards,
> > > > > Jan
> > > > >
> > > > > [1] https://github.com/sonatype/sonatype-
> > > > tycho/commit/ccbe5c2f2007da9ec0a0f9e25df8a36f740c2ff9
> > > > > [2] https://grid.sonatype.org/ci/view/Tycho/
> > > > >
> > > > >
> > > > > -----Original Message-----
> > > > > From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-
> > > > bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
> > > > > Sent: Donnerstag, 7. April 2011 13:32
> > > > > To: tycho-dev@xxxxxxxxxxx
> > > > > Subject: Re: [tycho-dev] first org.eclipse.tycho commit
> > > > >
> > > > > Correction. All integration tests pass too. I do not plan to make any
> > > > > changes to Tycho until you are done with package name changes.
> > > > >
> > > > > --
> > > > > Regards,
> > > > > Igor
> > > > >
> > > > > On 11-04-07 01:39 AM, Igor Fedorenko wrote:
> > > > > > Jan, Tobias,
> > > > > >
> > > > > > As discussed, I've updated all tycho projects to use org.eclipse.tycho
> > > > > > namespace in their groupId and artifact id and pushed my changes to
> > > > > > github [1].
> > > > > >
> > > > > > Everything compiles and all unit tests pass, but there are still three
> > > > > > or four failing integration tests. I'll look at them tomorrow. I also
> > > > > > need to deal with few prebuilt dependencies using old
> > > > org.sonatype.tycho
> > > > > > groupId (org.eclipse.jdt.core, org.eclipse.osgi and few of others used
> > > > > > by the tests).
> > > > > >
> > > > > > At this point I do not expect any major changes from "my" work, so you
> > > > > > can start updating package names.
> > > > > >
> > > > > > [1]
> > > > > > https://github.com/sonatype/sonatype-
> > > > tycho/commit/147dfdd685cab94f1212c6f1cd0ffaf4c72d8c47
> > > > > > --
> > > > > > Regards,
> > > > > > Igor
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-dev
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/tycho-dev