| Re: [tractusx-dev] Importance of Reviews |
|
Hi all, ready to review
https://github.com/eclipse-tractusx/.eclipsefdn/pull/43 votes are included Cheers Fabian Von: tractusx-dev <tractusx-dev-bounces@xxxxxxxxxxx>
Im Auftrag von Kiermayer, Siegfried via tractusx-dev [**EXTERNAL E-MAIL**]
Hey, That’s one very good reason to start pushing for this more ‘open and collaborative’ approach. If we never have this, it will stay ‘normal’ to just do it for your team but not looking left and right. Bye, Sigi From:
tractusx-dev <tractusx-dev-bounces@xxxxxxxxxxx> on behalf of Rizov Boris EXT Cluetec via tractusx-dev <tractusx-dev@xxxxxxxxxxx> Hi all, Generally I agree, but I don’t think that at the current state of things we’ll be able to progress fast enough. At least this is my impression at the moment. I really
struggle sometimes to get someone to review PRs in a timely manner, and I’m also guilty of not reviewing PRs on time (shoutout to Paul). Cheers Boris Von: tractusx-dev <tractusx-dev-bounces@xxxxxxxxxxx>
Im Auftrag von Paul Latzelsperger via tractusx-dev Hey, thanks. 2 approvals will be difficult to achieve in many situations. As a technically enforced rule, I am strongly in favor of reducing it to 1 approval. Paul From:
tractusx-dev <tractusx-dev-bounces@xxxxxxxxxxx> on behalf of fabian.gruen--- via tractusx-dev <tractusx-dev@xxxxxxxxxxx> Hi all, FYI:
https://github.com/eclipse-tractusx/.eclipsefdn/pull/43/files some Draft PR for enable branch protection, we can discuss on. Added at lease 2 approvals but we can also align on 1 approval. Cheers Fabian Von: tractusx-dev <tractusx-dev-bounces@xxxxxxxxxxx>
Im Auftrag von Kiermayer, Siegfried via tractusx-dev [**EXTERNAL E-MAIL**]
Hey, Totally agree we should add a rule for it. I’m doing this sometimes myself
☹ and still think its good
😊 Bye, Sigi From:
tractusx-dev <tractusx-dev-bounces@xxxxxxxxxxx> on behalf of Hellmeier, Malte via tractusx-dev <tractusx-dev@xxxxxxxxxxx> Dear Tractus-X Dev Community, I want to highlight the importance of reviews for our community. Since we are the biggest project in the Eclipse foundation and we already discussed the maintenance of overarching repositories
like the Docusaurus instance of eclipse-tractusx.github.io previously in the mail discussion, checks are essential to continue with high-quality outcomes. At this year's EclipseCon, they highly suggested reviewing every pull request by at least two reviewers. Since Tractus-X aligned for at least one reviewer, I wish that we take this decision as
the absolute minimum! During the last time, I saw different pull requests directly merged from the same person without any review or pull requests without any information in it (description) or with removed checkboxes of the standard template. Even if the
changes are minor, everything should be communicated clearly and checked by at least one person. Different Examples (no fingerpointing, just to show what I am talking about): https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/490 https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/513 https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/476 https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/474 https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/463 Hope you are going for the same opinion. Otherwise, I am happy to discuss it here. Thanks, and have a great week Malte Sidenote: Advent of Code is starting soon:
https://adventofcode.com/ -- Malte Hellmeier, M. Sc. Fraunhofer-Institut für Software- und Systemtechnik ISST
Wissenschaftlicher Mitarbeiter Logistik Speicherstraße 6, 44147 Dortmund, Germany Telefon +49 231 97677-464 malte.hellmeier@xxxxxxxxxxxxxxxxxx -------------------------------------------------------------------------------------------------- Folgen Sie uns:
|
