Re: [tractusx-dev] Importance of Reviews

[<fabian.gruen@xxxxxxxxxxxxxxxxx>]

Hi all,

guess we could add a branch protection rule against our web-page.

https://eclipse-tractusx.github.io/.eclipsefdn/repo-eclipse-tractusx.github.io/

Or you can check out if your Eclipse Tractus-X repo has a rule  https://eclipse-tractusx.github.io/.eclipsefdn/configuration/

Mit freundlichen Grüßen / Kind regards

Fabian Grün

Reliability Engineer

Mercedes-Benz Tech Innovation (ehemals/formerly Daimler TSS GmbH)

Wilhelm-Runge-Straße 11

89081 Ulm/Germany

fabian.gruen@xxxxxxxxxxxxxxxxx

www.mercedes-benz-techinnovation.com

       

 

Mercedes Benz Tech Innovation GmbH

Sitz und Registergericht/Domicile and Register Court: Ulm, HRB-Nr./Commercial Register No.: 3844

Geschäftsführung/Management: Daniel Geisel (Vorsitzender/Chairperson), Isabelle Krautwald

---

Von: tractusx-dev <tractusx-dev-bounces@xxxxxxxxxxx> im Auftrag von Hellmeier, Malte via tractusx-dev <tractusx-dev@xxxxxxxxxxx>
Gesendet: Mittwoch, 29. November 2023 16:20
An: tractusx-dev@xxxxxxxxxxx <tractusx-dev@xxxxxxxxxxx>
Cc: Hellmeier, Malte <Malte.Hellmeier@xxxxxxxxxxxxxxxxxx>
Betreff: [Caution: digital signature was invalid] [tractusx-dev] Importance of Reviews

 

[**EXTERNAL E-MAIL**]

Dear Tractus-X Dev Community,

 

I want to highlight the importance of reviews for our community. Since we are the biggest project in the Eclipse foundation and we already discussed the maintenance of overarching repositories like the Docusaurus instance of eclipse-tractusx.github.io previously in the mail discussion, checks are essential to continue with high-quality outcomes.

 

At this year's EclipseCon, they highly suggested reviewing every pull request by at least two reviewers. Since Tractus-X aligned for at least one reviewer, I wish that we take this decision as the absolute minimum! During the last time, I saw different pull requests directly merged from the same person without any review or pull requests without any information in it (description) or with removed checkboxes of the standard template. Even if the changes are minor, everything should be communicated clearly and checked by at least one person.

 

Different Examples (no fingerpointing, just to show what I am talking about):

https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/490

https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/513

https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/476

https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/474

https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/463

 

 

Hope you are going for the same opinion. Otherwise, I am happy to discuss it here.

 

Thanks, and have a great week

Malte

 

Sidenote: Advent of Code is starting soon: https://adventofcode.com/

--

Malte Hellmeier, M. Sc.

Fraunhofer-Institut für Software- und Systemtechnik ISST

Wissenschaftlicher Mitarbeiter Logistik

Speicherstraße 6, 44147 Dortmund, Germany

Telefon +49 231 97677-464

malte.hellmeier@xxxxxxxxxxxxxxxxxx
www.isst.fraunhofer.de

 

--------------------------------------------------------------------------------------------------

 

Folgen Sie uns: 

 

       

 

If you are not the addressee, please inform us immediately that you have received this e-mail by mistake, and delete it. We thank you for your support.