Hi Doug,
>Having just cleaned up my internal serial port/terminal implementation to get back to the old Terminal View, I got an appreciation of how simple the old view
is to extend and >how the TCF Terminal integration was more than doubled the size of the code. If we’re going to go with that as our one terminal implementation, I’d like to see how we can >simplify that.
It is not doubling the code, and it got already simplified to what you may have seen. However, setting up the view and establishing the terminal connection are
two different things. With the old terminal those things are simply not separated and you can easily think that you have to do just one thing and that’s it. In fact, the terminal connector is mixing things and is very unnecessary half terminal connector and
half view setup. And as we take out the unnecessary pieces from the terminal connector plug-ins, there will be less “double” code.
> I also want to see a tighter integration with o.e.remote. All the terminal types can be implemented using remote services with the bonus that they also support
other UI
>elements.
There is basically nothing wrong with that. If one terminal connector can be used for all 3 connector types we have today, contributions will be welcome. However,
what we like to see is a clear separation between the terminal control, the terminal connector logic and the view the terminal control is embedded into. One core feature of the terminal widget is still that you can embed the terminal control in other views
and I think that we want keep that capability.
>I just want to click on my Connection in the Connections view and Open Terminal or Open File Browser and the right things happen.
And here you describe the exact behavior of the Target Explorer. But of course you will teach me how wrong the Target Explorer is by doing exactly the things
you keep demanding. Needless to mention that the Target Explorer does have a file browser which does support drag and drop. … Nevermind.
Best regards, Uwe
J
From: tm-dev-bounces@xxxxxxxxxxx [mailto:tm-dev-bounces@xxxxxxxxxxx]
On Behalf Of Doug Schaefer
Sent: Dienstag, 24. Februar 2015 17:13
To: TM project developer discussions
Subject: Re: [tm-dev] "Terminals" view dependency reduction
Importance: High
+1. It’s more an issue when you want to move committers from one project to another. Since you’re committers on both, just fire it over.
Having just cleaned up my internal serial port/terminal implementation to get back to the old Terminal View, I got an appreciation of how simple the old view
is to extend and how the TCF Terminal integration was more than doubled the size of the code. If we’re going to go with that as our one terminal implementation, I’d like to see how we can simplify that.
I also want to see a tighter integration with o.e.remote. All the terminal types can be implemented using remote services with the bonus that they also support
other UI elements. With my user hat on, I’m not sure why creating a Terminal and opening a File Browser over the same wire would require different frameworks. I just want to click on my Connection in the Connections view and Open Terminal or Open File Browser
and the right things happen. (And, yes, I’ll be adding a file browser with full drag and drop to the o.e.remote UI probably in the Mars.1 timeframe).
Is a move review even necessary? I think this is only for when whole projects move. In this case, I think you could just create a Gerrit patch and submit it to
the TM repo.
Remaining issues have been fixed, and the refactored terminals view is now available from our Marketplace
entry [1] as well as directly from our p2 repository:
In order to look at the source, you can simply File > Import > Team > Project set from this URL:
to get all the necessary repos in one step (TM, o.e.remote, TCF) with projects categorized into Working Sets.
We now need to decide on the next steps to
ensure that we can align on this as the common Terminals view for Eclipse.
If a Move Review / Restructuring Review is desired to move over the sources into TM, we’d appreciate guidance from Greg and Doug.
The alternative would be just updating the EPP packages to use the new terminals view instead of the now deprecated legacy one.
Comments or thoughts are most welcome at this point !
Martin Oberhuber, SMTS / Product Owner – Development Tools, Wind
River
direct +43.662.457915.85 fax +43.662.457915.6
Please note that the proposed dependency reduction for the “Terminals” view implementation has been completed. If you install the terminals feature from our nightly
build repository [1], you want see any other o.e.tcf feature/plug-in, nor will you get GSON. The only external dependency the “Terminals” view have is to org.eclipse.cdt.core.native to support the local terminal functionality. The marketplace contribution
will be updated soon.
_______________________________________________
tm-dev mailing list
tm-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tm-dev
|