Hi Greg,
With the remote terminal service included, the terminal suddenly has a dependency to org.eclipse.remote, something not living in the TM project, at least
not yet. Dependencies to an external project, something you and Doug S. have had complained about vehemently lately. Never mind!
Except from that, I don’t see any issue with this contribution.
One thing, are you open to get the feature renamed to have the feature(s) explicitly named “<id>.feature” or are you locked already to the current names of
the features? And we also would like to split up the features in a runtime feature (no sources) and an SDK feature (with sources). It reduces the download size of Eclipse based products bundling the Terminal.
Best regards, Uwe
From: tm-dev-bounces@xxxxxxxxxxx [mailto:tm-dev-bounces@xxxxxxxxxxx]
On Behalf Of Greg Watson
Sent: Freitag, 30. Jänner 2015 20:59
To: TM project developer discussions
Subject: [tm-dev] Remote terminal service
I’d appreciate it if someone would take a look at https://git.eclipse.org/r/40575 and let me know if you see any issues. Other than being included in the terminal feature, there shouldn’t be
any interaction with other terminal services.