Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [skalli-dev] Howto associate git commits with bugzilla issues
Thanks.

But: Britta was right, the EGit explanation is more comprehensice. I've taken it and put it into a "Contributing patches" section.

Fine for all?

Jochen

On Thu, May 12, 2011 at 4:52 PM, Ochmann, Michael <michael.ochmann@xxxxxxx> wrote:

I fixed the example. There was just the Bug: header missing and the bugzilla link was broken.

Regards

Michael

 

From: skalli-dev-bounces@xxxxxxxxxxx [mailto:skalli-dev-bounces@xxxxxxxxxxx] On Behalf Of Varwig, Britta
Sent: Donnerstag, 12. Mai 2011 16:37


To: Skalli project developer mailing list
Subject: Re: [skalli-dev] Howto associate git commits with bugzilla issues

 

? I am confused a little.

 

I think the example in the wiki does not fully match to what Michael suggested.

 

Any doubts to change the wiki and copy the content from egit to Skalli?

 

Regards Britta

 

 

 

From: skalli-dev-bounces@xxxxxxxxxxx [mailto:skalli-dev-bounces@xxxxxxxxxxx] On Behalf Of Jochen Hiller
Sent: Donnerstag, 12. Mai 2011 16:27
To: Skalli project developer mailing list
Subject: Re: [skalli-dev] Howto associate git commits with bugzilla issues

 

Done: http://wiki.eclipse.org/Skalli/Contributor_Guide#Committers_Message_Guidelines

 

On Thu, May 12, 2011 at 3:20 PM, Jochen Hiller <jo.hiller@xxxxxxxxxxxxxx> wrote:

+1.

 

If we all agree on Michaels proposal, I will add this to the contributors guide, excellent idea Britta.

 

Bye, Jochen

On Thu, May 12, 2011 at 3:12 PM, Varwig, Britta <britta.varwig@xxxxxxx> wrote:

1+ I like that suggestion !

 

This is more or less the same as git itself handle this:  http://wiki.eclipse.org/EGit/Contributor_Guide#Commit_message_guidelines

(they make some thins more expliziet)

 

Suggestion:

Add a our final commitment to http://wiki.eclipse.org/Skalli/Contributor_Guide#Commit_message_guidelines as well.

 

Regards Britta

 

 

From: skalli-dev-bounces@xxxxxxxxxxx [mailto:skalli-dev-bounces@xxxxxxxxxxx] On Behalf Of Ochmann, Michael
Sent: Donnerstag, 12. Mai 2011 14:38
To: skalli-dev@xxxxxxxxxxx
Subject: [skalli-dev] Howto associate git commits with bugzilla issues

 

Hi all,

since more and more patches come in through bugzilla, we should agree on how we want to associate a commit fixing a certain bug and the corresponding bugzilla issue.  I looked around a bit what other git based projects are doing, i.e. jgit and egit, and they seem to prefer the following format (example):

 

Ignore submodule commits during checkout

 

Submodules are supposed to be handled by separate operations, so

we should …

 

Bug: 343566

Change-Id: I2c5ae1024ea7bb57adf27072da6acc9643018eda

Signed-off-by: Robin Rosenberg robin.rosenberg@xxxxxxxxxx

 

 

Are there other suggestions or best practices?

 

Regards

Michael

 

_______________________________________________
skalli-dev mailing list
skalli-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/skalli-dev

 

 


_______________________________________________
skalli-dev mailing list
skalli-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/skalli-dev


Back to the top