Re: [servlet-dev] Moving Servlet TCK tests to the Servlet Specification

[Olivier Lamy <olamy@xxxxxxxxxxx>]

Hi,

It looks like Greg and Mark have approved the PR.

Do you know when this will get merged? or if I could get karma to do it?

I would like to move forward with this then I will have some changes because of the move in platform tck and make some more improvements in servlet TCK itself.

Thanks

Olivier 

On Thu, Oct 5, 2023 at 4:43 PM Olivier Lamy <olamy@xxxxxxxxxxx> wrote:

On Wed, Oct 4, 2023 at 6:40 PM Mark Thomas via servlet-dev <servlet-dev@xxxxxxxxxxx> wrote:

On 04/10/2023 01:04, Olivier Lamy via servlet-dev wrote:
> Hi,
> Some update on ETA of this servlet TCK code in the servlet repo.
> I did most of the changes (still more improvement, but it can be done
> later).
> In the Jetty project, we run this TCK against Jetty every day:
> https://jenkins.webtide.net/job/tck/job/tck-servlet-arquillian-experiment/job/jetty-12-ee10-servlet-tck-spec-repo/ <https://jenkins.webtide.net/job/tck/job/tck-servlet-arquillian-experiment/job/jetty-12-ee10-servlet-tck-spec-repo/>
> This refactored TCK run takes about 14 minutes (vs 1h5m with current TCK)
> We do have the same TCK error number. They are all due to the
> non-implementation of cross-context with Jetty 12.
> See https://github.com/jakartaee/servlet/issues/488
> <https://github.com/jakartaee/servlet/issues/488>, that's something I'd
> like to implement once we have this merged.
> I have done some tests with Tomcat as well. Some issues I'm not quite
> sure of the reason

I can look at those.

> There is a repo here with the setup project
> https://github.com/olamy/servlet-tck-tomcat
> <https://github.com/olamy/servlet-tck-tomcat>.
> main branch is based on general tck with tckrefactor branch and
> branch tck-from-servlet-repo is based on tck from the servlet repo.
> (@Mark if you want to use that somewhere in Tomcat I'm happy to push it
> there as I still should have my commit karma)

Tx. I have some stuff setup locally for the refactored TCKs. I planned
to use that to create a separate project for running all the TCKs Tomcat
uses. I'll have a look at your repo and probably use bits of both.

> There are still some improvement to do on the old code base especially
> on the error reporting but I see this a as a good start.
>
> Thoughts?

My suggested way forward is:

- get this merged
- get you commit karma (if you don't already have it)
- you (and any other committer) are free to continue refactoring /
   improving as long as the behavior does not change
- behavioral changes require review and agreement
- start implementing the changes we know we need for the changes in the
   spec

Looks good to me. (I don't have commit karma here)

 

Mark
_______________________________________________
servlet-dev mailing list
servlet-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/servlet-dev

--

Olivier

--

Olivier