Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [servlet-dev] Runtime Discovery of Servlet Mappings and getNamedDispatcher

Hi,

The spec is not super clear indeed. There's some more information here though in the original discussion. It's too late here now to fully read it, but I'll take a look at it tomorrow:


Would perhaps also be good to have the TCK tests updated to fully cover the table in https://github.com/eclipse-ee4j/servlet-api/issues/309.

Kind regards,
Arjan Tijms




On Tue, May 11, 2021 at 12:18 AM Greg Wilkins <gregw@xxxxxxxxxxx> wrote:

See some discussion related to this at  https://github.com/eclipse-ee4j/servlet-api/issues/309
But it unfortunately does not include a column for named forward and named include.

However I think the test is right, in that a named dispatch doesn't change the target information returned by the path/mapping methods... but I assume it changes behaviour of isUserInRole etc.?

So the language "is not available" is kind of correct, but also misleading.   The mapping for the target is not available, but the original mapping is still available.

So that language could be improved.  Perhaps we should update that table from #309 with a complete picture of how all methods change under all dispatches and include that in the spec ?

I also note another question about this method at https://github.com/eclipse-ee4j/servlet-api/issues/316

regards


--
_______________________________________________
servlet-dev mailing list
servlet-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/servlet-dev

Back to the top