[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [science-pmc] [CQ 12753] science.scanning
|
I would be happy to approve this CQ at the highlevel, i.e. it is an
expected IC for an approved project.
I am not clear on our (science-pmc) responsibilities here, the IP
poster (https://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf)
does not say much, the technology-pmc's site says a bit more:
https://wiki.eclipse.org/Technology#Approve_Intellectual_Property_.28IP.29_Contribution_Questionnaires_.28CQ.29
The technology.pmc's list has basically checking that
https://www.eclipse.org/legal/guidetolegaldoc2.php has been followed,
plus Try to reduce bloat. There are a lot of checkboxes on there and a
number of them haven't been met. But I assume that IP people have
tools that check this automatically.
For example, there is no about.html in every bundle and the
package-info.java files don't have copyright header.
I don't really want to do the check manually if there is automation later.
Additionally, "Author(s): Self", I assume that other people at
DLS were involved in coding this :-)
side-bar I am not fond of this:
* There is no strict format for code, such as you must indent using a
tab rather than four spaces or your imports should be in a specific
order. Or a line limit other than the one Java suggests. If a reviewer
asks for this you should refer to this guideline!
but if you have that, I am glad you have:
* Avoid reformatting code just for 'readability' because it creates
false diffs. Better to tolerate the original developer's formatting.
Having worked on the 15 year old CDT project for a long time, it is an
absolute nuisance that random files are formatted in randomly
different ways. I am very fond of the growing number of projects that
enforce (via automation) strict code formatting rules. For example
py4j and PyDev are now in this situation and the code is easier to
work on because you can rely on the tools to help (like formatting).
Jonah
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com
On 16 February 2017 at 17:00, <emo-ip-team@xxxxxxxxxxx> wrote:
> http://dev.eclipse.org/ipzilla/show_bug.cgi?id=12753
>
>
> Genie Eclipse <genie@xxxxxxxxxxx> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Severity|new |awaiting_pmc
>
>
>
>
> --- Comment #6 from Genie Eclipse <genie@xxxxxxxxxxx> 2017-02-16 12:00:03 ---
> This CQ is currently awaiting PMC Approval. PMC members only, please use the
> PMC_Approved flag on this CQ to indicate your approval (flag set to "+") or
> disapproval (flag set to "-").
>
>
> --
> Configure CQmail: http://dev.eclipse.org/ipzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the CQ.
> _______________________________________________
> science-pmc mailing list
> science-pmc@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/science-pmc
