[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [sapphire-dev] SapphireDiagramEditorPagePart adapt()
|
Thanks, I created ticket and attached a patch with your suggested change.
https://bugs.eclipse.org/bugs/show_bug.cgi?id=374022
On Tue, Mar 13, 2012 at 12:21 AM, Konstantin Komissarchik
<konstantin.komissarchik@xxxxxxxxxx> wrote:
The problem is that SapphireDiagramEditor fails to pass in parent part (SapphireEditor) when initializing SapphireDiagramEditorPagePart on line 120 as contrasted with line 230 in MasterDetailsEditorPage where this is done correctly. Fixing this issue will make the IEditorSite adapt usecase work. Please open a bug report.
- Konstantin
Hey sapphire team,
In an actionHandler for a masterDetailsPagePart I am able to call context.getPart().adapt(IEditorSite.class) and this will work because of the SapphireEditor.adapt() method in the page parent hierarchy.
Now I have a SapphireDiagramHandler that is fired off of a double-click action for a particular node in my diagram. In this actionhandler which I have the context I'd like to be able to get the IEditorSite but the SapphireDiagramEditor doesn't seem to support this. Do you think we could add this to the SapphireDiagramEditor? I have attached a patch that works for me, but I didn't want to bother with creating bugzilla entry unless the team thought this would be a good enhancement. Perhaps there is alternatives that wouldn't require patching.
_______________________________________________
sapphire-dev mailing list
sapphire-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/sapphire-dev
--