Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [riena-dev] Deprecate IActionListener.addListener(Object, String) ? 
Other places worth looking at might be
    IRidget>>addPropertyChangeListener(...)
    ISelectableRidget>>addSelectionListener(...)
    ITableRidget>>addDoubleClickListener(...)
    ITreeRidget>>addDoubleClickListener(...)
Listeners requiring 2 methods:
    IRidget>>addFocusListener(...) [-> addFocusListener(Object target, String onFocusGained, String onFocusLost)]
    IWindowRidget>>addWindowRidgetListener(...) [-> addFocusListener(Object target, String onActivated, String onClosed)]

(btw, the ISelectionListener interface seems a little bit strange as its only method is #ridgetSelected(SelectionEvent). I would have expected something like selectionChanged(SelectionEvent) as it is not the ridget that gets selected but the selection within the ridget that changes)

Having simple and lean interfaces is a very valid point. But I think the above methods would not inadequately blow up the interfaces.
 
well, the Döner plate will have to wait until you're in Frankfurt... meanwhile I'll have a very good Tagliata in 7bello tonight :-)
________________________________________
From: riena-dev-bounces@xxxxxxxxxxx [riena-dev-bounces@xxxxxxxxxxx] On Behalf Of Elias Volanakis [elias@xxxxxxxxxxxxxxxxx]
Sent: Tuesday, September 01, 2009 19:37
To: Riena Developers list
Subject: Re: [riena-dev] Deprecate IActionListener.addListener(Object, String)  ?

My take away points on IActionListener#addListener(Object target,
String action):
- returning the listener instead of void  (+1 from me)
- it is used (though not in Riena code)


What struck me strange is that IActionListener is the _only_ place in
the ridgets where this idiom (i.e. addListener(target, action))
appears.

- do we need so much that it has to be in the interface? It is also a
simplification to not have too many similar methods in the interface
(both for extenders of Riena and users). Besides, this could be done
with a factory at the cost of one additional argument.

- are there other places this pattern makes sense?

Would love to discuss it over a tasty Doener plate (no good place
here), but looking forward to the discussion here.

Kind regards,
Elias.

--
Elias Volanakis | Technical Lead | EclipseSource Portland
elias@xxxxxxxxxxxxxxxxx | +1 503 929 5537 | http://eclipsesource.com
_______________________________________________
riena-dev mailing list
riena-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/riena-dev

No virus found in this incoming message.
Checked by AVG - www.avg.com
Version: 8.5.409 / Virus Database: 270.13.74/2339 - Release Date: 09/01/09 06:52:00

Back to the top