| Release went well.
Håvard On 4 Aug 2021, at 10:12, Håvard Ottestad <hmottestad@xxxxxxxxx> wrote:
Great!
I’ll merge it when it’s green and then start the release :)
Håvard
On Wed, 4 Aug 2021, at 17:44, Håvard Ottestad wrote:
Hi Jeen,
Thanks for merging that branch and looking at the draft one.
I fixed the public method and reverted a few things I felt were more enhancements rather than bug fixes.
Could you merge it before you release? If it passes all the sets, and you have time to wait for it, and you agree that it can make it into 3.7.2!
All looks good to me, have approved it. Happy to merge it (or have you merge it) when it's green.
PS. I have time to run the release today, so if you’d prefer to relax after dinner then I can run the scripts and get the release out the door and create the release notes so you can take a look and publish them tomorrow morning. Up to you :)
Oh, thanks! Would you please? I'll happily take a look at the release notes tomorrow.
Cheers,
Jeen
Thanks Havard, I merged one of yours, and left the draft one open (had one comment on it that I think we should address before merging). There's two other PRs of you that target the develop branch, so haven't looked at those in too much detail. There's also a few older PRs of you that I'm not sure what the current state is.
I'm happy with the state of the main branch now, I'll start the release process shortly (after dinner, probably, so in about an hour from now). Let me know if there's any things I overlooked or any last-minute things we still want to squeeze in.
Cheers,
Jeen
On Tue, 3 Aug 2021, at 17:52, Håvard Ottestad wrote:
Hi,
Jeen, could you take a look at my last few PRs? Would really appreciate it :) I think I’ve added you as a reviewer on most of them.
One of them is still marked as draft. If you have the time I would be very grateful for a review of that one too. I will try to detangle it so the parts that are bug fixes can be separated out from them rest, but it’ll have to wait til tonight.
Håvard
Thanks Andreas, I haven't done a fully immersive review but from what I've been able to see the fix looks like a good one. I've approved, as has Damyan, so happy for you to merge it in.
I suggest we run a 3.7.2 release middle of next week. Havard, anything on your end that is not ready to merge yet can just move over to either a 3.7.3 release, or better yet, go straight into a 4.0.0 release.
Regarding the 4.0 schedule: I'd like us to get the 4.0 (develop) branch into a releasable state ASAP, and try and do a milestone build that covers at least all the deprecation/removals, and if at all possible the new Spring components by Jerven and Florian, by early September.
Jeen
On Thu, 29 Jul 2021, at 01:04, Andreas Schwarte wrote:
Hi all,
In our recent use-cases we also observed some strange behavior and invested quite a bit of time in investigation.
During my validations throughout the last days I however found a number of further reproducible issues. In my branch I now have combined Damyan's changes as well as solutions to my findings: https://github.com/eclipse/rdf4j/pull/3255
As these fixes would benefit us a lot in our product (and potentially also Ontotext in their use-cases) I would like to ask whether we can make them available in the upcoming 3.7.2 release.
I think technical discussion, as well as how we practically combine the contributions we can do on the PR. On this mailing list I wanted to bring this to all of your attention.
Any feedback and reviews appreciated.
Thanks,
Andreas
_______________________________________________
rdf4j-dev mailing list
_______________________________________________
rdf4j-dev mailing list
_______________________________________________
rdf4j-dev mailing list
_______________________________________________
rdf4j-dev mailing list
_______________________________________________
rdf4j-dev mailing list
_______________________________________________rdf4j-dev mailing listrdf4j-dev@xxxxxxxxxxxTo unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev
|
