Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rdf4j-dev] windoHws line endings and our tests
  • From: "Bart Hanssens (BOSA)" <bart.hanssens@xxxxxxxxxxxx>
  • Date: Tue, 13 Apr 2021 06:46:51 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bosa.fgov.be; dmarc=pass action=none header.from=bosa.fgov.be; dkim=pass header.d=bosa.fgov.be; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3F4wZcRPsfTTMrAedlqVulvzaZmyshgT6Zb67BeHXRU=; b=jHXvNBEddA41h0naPz7mI+1LxC3Cj63EoPNVGCaPBSDwGq5bkt8Znq7qT7PM4MKtRIt4LvrxHliHwet04pHNLC+hnrL7F4rxnxb+OLzE3ZUFhio2MBkr4XjtZqtYleSmcAQMg3w6sGmNO6IJElzxdu3KW5nS3U6hMFqVMT9iVkWz3vym4cDbWe4FRImGoK3ZIYxoevLzFiPGv3HdPIILGywK6CZWzuA5jitE5RkgfhX4QTWTa3L20lDDNor0OwWZ4q8Qwh+VSHchQIhnRSXlJShqSQhZ8MZlQVWlniWsKjfEAkdqzMRJSvsNIs70fzJ6zUQghT8oZbNN6xMGweyqzA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FL8hQSNQkerE58X0ZZbqfZ3xmpq7McrvTXpcixiBAMgk9ENq1GF3alSEqIHlcqqOrqkpKpsKUVy9ZZGLpCAa0AsbX03sMTSG+RZxmNWhuqtorE/uxl82OWg6gX2T9jTE/WimMJ9PX1CQPamVK/BNrPBR0AACtFoTYr3BYNw678b08/RD29CTasORyp3SsQGtEB6+Zm+Ns/h6lK6nEwgQa47GlbUMVZkGd1edtJ9s/Rv8nvfHAzZfyxoDistze6MzEmTWv1hxy4VNKN8AZEV51cRKS+JF7bVlb4Em+C784F0xy5+p98KtGpxmM7FdsIu03DiOpn701TFaSxmXXs8VWg==
  • Delivered-to: rdf4j-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/rdf4j-dev/>
  • List-help: <mailto:rdf4j-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/rdf4j-dev>, <mailto:rdf4j-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/rdf4j-dev>, <mailto:rdf4j-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AdcwK9pRzUH3gk2mSiiZ0+jq4CnsYA==
  • Thread-topic: [rdf4j-dev] windoHws line endings and our tests
Hmm yes, I do remember having seen / used System.lineSeparator() in at least one test (ArrangedWriterTest ?).
But not sure if it's still used...

I can try running the full test suite on Windows to see what comes up...

Best regards

Bart

-----Original Message-----
From: rdf4j-dev <rdf4j-dev-bounces@xxxxxxxxxxx> On Behalf Of Håvard Ottestad
Sent: dinsdag 13 april 2021 7:29
To: rdf4j developer discussions <rdf4j-dev@xxxxxxxxxxx>
Subject: Re: [rdf4j-dev] windows line endings and our tests

Btw. I’ve had tests fail in IntelliJ before, but pass with maven. 

Which test was it? I can try in IntelliJ on my mac. 

Håvard

> On 13 Apr 2021, at 06:05, Jeen Broekstra <jeen@xxxxxxxxxxxx> wrote:
> 
> 
> This recently came up again because we have a new contributor who has seen some tests failing, where I _think_ the issue is likely one of line endings (they are on Windows). 
> 
> Now, as far as I know our git repo is set up to handle this properly, in .gitattributes. However, some of our tests in the suite rely on things like "check that this produced string is exactly equal to this hardcoded string", and we tend to use "\n" in there. A good example is org.eclipse.rdf4j.query.algebra.evaluation.impl.QueryCostEstimatesTest.
> 
> Bart, I believe you work on Windows as well. Do you remember having to do anything special on your end in order for such tests to run successfully?
> 
> Jeen
> _______________________________________________
> rdf4j-dev mailing list
> rdf4j-dev@xxxxxxxxxxx
> To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev
_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev

Back to the top