[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [rdf4j-dev] Extended branch protections
|
I must admit I occasionally do it on purpose as well, it's very easy to think "oh this is so trivial, I dont want to create a ticket and a PR for it and having to wait for the build to finish", but in the end I think for stability and record-keeping purposes it's better to be a little bit stricter about this.
Branch protections are now in place - but it looks as if they also enabled the "Require branches to be up to date before merging" option, which is not something I want to require (it means we'd have to update every outstanding PR as soon as something gets merged). I've asked them to change that part back.
Cheers,
Jeen
On Mon, Sep 14, 2020, at 15:48, Håvard Ottestad wrote:
Hi,
I recently pushed to master to fix a flaky test. I really like being able to push to master and develop directly.
That said I agree that this is a good thing, since I think it’s better to move slow and not break things than to move fast and mess if up for everyone else.
Cheers,
Håvard
hi folks,
I recently pushed a fix directly to master, by accident. Although no real harm was done, it's bad practice, and it got me thinking that we should have some protection against that sort of thing in place.
To that end, I've asked the Eclipse admins to slightly tighten our branch protections on both master and develop. It is now (or at least, as soon as they've tweaked our config for us) required that the build succeeds before a PR can be merged. This also automatically ensures that no-one can push directly to master or develop: you _have_ to use a feature branch and create PR.
Note that I've deliberately not enabled the ECA check, or requiring review approval, as the first sometimes just gets it wrong, and the second is often hard to obtain in time with not all of us able to review PRs on a daily basis.
Cheers,
Jeen
_______________________________________________
rdf4j-dev mailing list
_______________________________________________
rdf4j-dev mailing list
