Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rdf4j-dev] Github CI changes

Nice!

I am considering whether we should have these pre-steps as completely independent actions instead - that way you get more detailed feedback directly on the PR as it will tell you that the "formatting check" action failed, instead of "PR unit test" failing and then you have to dig in to see it failed on the formatting.  But I need to do a bit more reading up, there might be other ways to address that.


Jeen

On Thu, Nov 28, 2019 at 12:48 AM Håvard Ottestad <hmottestad@xxxxxxxxx> wrote:
Hi,

I’ve added a jdk 8 and jdk 11 matrix builds (it runs everything in both version) to the Github CI files (they call it Actions).

I’ve also added two pre-steps.

1. Run formatter:validate to check that the files were formatted correctly.
2. Run mvn install without tests to verify that the code compiles and builds.

This makes it easier to diagnose typical issues like forgetting to format or having a compile error.

Doesn’t increase the CI time. Also the matrix builds run in parallel :)

Håvard
_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/rdf4j-dev

Back to the top