[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [ptp-dev] Problems trying to create resource manager using XML framework
|
Great. I suggest removing it from the extension point if it's no longer needed.
Greg
On Apr 30, 2011, at 7:28 PM, Albert L. Rossi wrote:
> Done. The id is now totally arbitrary. -A;
>
> ----- Albert L. Rossi <arossi@xxxxxxxxxxxxx> wrote:
>> Great, I'll take care of it.
>>
>> Al
>> ----- Greg Watson <g.watson@xxxxxxxxxxxx> wrote:
>>> Al,
>>>
>>> I had a quick look and I don't think there is any need to change RMProviderContributor. I think you just need to modify JAXBRMConfigurationSelectionFactory so that it ignores the id altogether. The id in the org.eclipse.ptp.rm.jaxb.core.JAXBResourceManagerConfigurations extension point is not used by anything in RMProviderContributor. fRMJAXBResourceManagers map can just be reduced to Map<String, URL>.
>>>
>>> Greg
>>>
>>> On Apr 30, 2011, at 3:38 PM, Albert L. Rossi wrote:
>>>
>>>> Greg, Dave
>>>>
>>>> This is a follow-up to the discussion about the "id" attribute on the org.eclipse.ptp.rm.jaxb.core.JAXBResourceManagerConfigurations extension point. That attribute points to the _selection factory_ (org.eclipse.ptp.ui.wizards.RMConfigurationSelectionFactory).
>>>>
>>>> If you change it, you have to implement a new selection factory as well. But there is no need, because
>>>>
>>>> org.eclipse.ptp.rm.jaxb.ui.wizards.JAXBRMConfigurationSelectionFactory
>>>>
>>>> is written to handle all contributions to this extension point. It's id is "org.eclipse.ptp.rm.jaxb.JAXBServiceProvider"
>>>>
>>>> At this point I'm not sure what the correct thing to do is; the id may be redundant, or it could be useful if a special corner-case configuration needs to be created (but that sort of defeats the purpose of this undertaking); hence I would be inclined to remove it from the extension point. However, that will inevitably entail changes to
>>>>
>>>> org.eclipse.ptp.ui.wizards.RMProviderContributor,
>>>>
>>>> private static void getRMConfigurationSelectionFactories() [ll. 58ff.].
>>>>
>>>> This is basically your domain Greg. Let me know what to do (I know you are currently overloaded).
>>>>
>>>> For the moment, Dave, continue to set that id to "org.eclipse.ptp.rm.jaxb.JAXBServiceProvider" for all contributors to the extension point.
>>>>
>>>> Al
>>>> _______________________________________________
>>>> ptp-dev mailing list
>>>> ptp-dev@xxxxxxxxxxx
>>>> https://dev.eclipse.org/mailman/listinfo/ptp-dev
>>>
>>> _______________________________________________
>>> ptp-dev mailing list
>>> ptp-dev@xxxxxxxxxxx
>>> https://dev.eclipse.org/mailman/listinfo/ptp-dev
>>>
>>
>> _______________________________________________
>> ptp-dev mailing list
>> ptp-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/ptp-dev
>>
>
> _______________________________________________
> ptp-dev mailing list
> ptp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ptp-dev
