Re: [ptp-dev] Fwd: Re: submitting Jobs

["Albert L. Rossi" <arossi@xxxxxxxxxxxxx>]

Roland,

Is this what you mean?  Or are you sending back an this event after submission from the client completes (i.e., the call to submit returns from the proxy, but the proxy then discovers something wrong with the submit configuration)?

Greg,

I had thought that a submission error would be handled in the layers above the specific ResourceManager.  However, I also thought I would try the following:

- Make the PBSLaunchConfigurationTab implement IResourceManagerListener;
- Add this to the passed in IResourceManager on initializeFrom
- Implement an error message using the errorDialog methods in the org.eclipse.ptp.launch.PTPLaunchPlugin 

This is a bit kludgy, but I wanted to see if it captures the error Roland says is not being displayed.  

Al

*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*
"History does not repeat itself, but often it rhymes." (attr. Mark Twain)

----- Greg Watson <g.watson@xxxxxxxxxxxx> wrote:
> Good question, but I think it's already dealt with. It looks like the event is eventually translated into an IResourceManagerSubmitJobErrorEvent that is handled by the launch system:
> 
> 1. First, IProxyRuntimeSubmitJobErrorEvent is translated into IRuntimeSubmitJobErrorEvent in org.eclipse.ptp.rtsystem.AbstractProxyRuntimeSystem#handleEvent.
> 
> 2. Next, IRuntimeSubmitJobErrorEvent is translated into IResourceManagerSubmitJobErrorEvent in org.eclipse.ptp.rmsystem.AbstractRuntimeResourceManager#handleEvent. 
> 
> 3. This event is then handled in org.eclipse.ptp.launch.AbstractParallelLaunchConfigurationDelegate.RMListener#handleEvent which set the status of the job. 
> 
> 4. Finally, org.eclipse.ptp.launch.AbstractParallelLaunchConfigurationDelegate#submitJob checks the submission status, and if the status is an error, it raises a CoreException. This will create a dialog containing the error message.
> 
> Note that this event is generated only if the job *submission* fails, so it is before the job is actually created in the model. Hence the job status icons can't be used to indicate the error. 
> 
> Regards,
> Greg
>  
> On Apr 6, 2010, at 3:11 PM, Albert L. Rossi wrote:
> 
> > Greg,
> > 
> > I'm posting a question to the list because I think I need a little guidance.
> > 
> > We have a very basic, hard-coded version of the PBS Launch Tab working, and I'm trying to move now to the next step of implementing one which is not just a place-holder for testing.  
> > 
> > One of the issues which came up when Roland used the Run Configuration to launch against the PBS proxy was in terms of the propagation of an IProxyRuntimeSubmitJobErrorEvent and its eventual exposure to the user.  There are handlers implemented for intercepting job submission events in the AbstractRTSystem classes, but the final listener seems to be missing at that level which would do something (like an error message widget) with it.  Am I mistaken?
> > 
> > If it is missing, where should the listener reside (it's not really PBS-specific, I don't think), and I'm also a bit uncertain as to how to create hooks for adding the necessary listener to the RTSystem class from UI parts (the listener obviously should not live in the org.eclipse.ptp.rm.core plugin, since it is UI-specific).
> > 
> > Thanks for any help you can give here.
> > 
> > Al
> > _______________________________________________
> > ptp-dev mailing list
> > ptp-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/ptp-dev
> 
> _______________________________________________
> ptp-dev mailing list
> ptp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ptp-dev
>