Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ptp-dev] Need multiple file selection in IRemoteUIFileManager class

Dave,

I'm happy if you want to go ahead and change the interface to return multiple selections.

I've been having second thoughts about using IPath in the remote interfaces since it is really meant for local paths. Since we're changing the interface anyway, I'd suggest returning String[] rather than IPath[].

Greg

On Oct 12, 2009, at 9:11 AM, Dave Wootton wrote:

I'm working on my plugin which uses IRemoteUIFileManager to display a file
selector dialog to get the pathname of remote files. I found that this
class only allows single file selection while I have a case in my plugin where I need multiple file selection in order to be compatible with the
existing implementation.

I looked at IRemoteUIFileManager, LocalUIFileManager,
RemoteToolsUIFileManager and RSEUIFileManager, as well as the
RemoteResourceBrowser class used by RemoteToolsUIFileManager. Most of this
looks pretty easy,with RemoteResourceBrowser being a little more
complicated. I think the handling of the tree selection in that class just needs to be fixed up to look at multiple selections and return an array of
String objects as well as the single String selection.

I can implement a 'public IPath[] browseFiles(Shell, String, String)'
method if you think that's reasonable. I just need to make the time to do it. I'm not sure how I would set up the appropriate connections to test
each of these classes though.

I also noticed that even though LocalUIFileManager.browseFile allows the user to select multiple files it only returns a single IPath object. I'd
fix that method to allow only a single selection as well.
Dave
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev



Back to the top