Re: [ptp-dev] launch changes

[Wyatt Spear <wspear@xxxxxxxxxxxxxx>]

Thanks for making those changes Greg.  I'll take a look at that
re-instantiation of the launch delegates, I'm not sure why it was coded
that way but I'm guessing it's not necessary.

-Wyatt

On Tue, May 12, 2009 at 9:38 AM, Greg Watson <g.watson@xxxxxxxxxxxx> wrote:

Hi,

I've made some changes to the PTP launch configuration:

1. A mechanism to get notification of job state changes has been added. To use this, provide a class that implements ILaunchNotification, then register it by calling PTPLaunchPlugin.addLaunchNotificationListener. The jobStateChange method will then be invoked whenever the state of the job changes.

2. The visibility of the ParallelLaunchConfigurationDelegate has been increased. I noticed that the external tools framework was extending this, but it was in an internal package.



Wyatt, a question. I notice that your code is doing this:

public class ParallelPerformanceLaunchConfigurationDelegate extends ParallelLaunchConfigurationDelegate  [
...
       public void launch(ILaunchConfiguration configuration, String mode, ILaunch launchIn, IProgressMonitor monitor) throws CoreException
       {
               ...
               PerformanceLaunchManager plaunch=new PerformanceLaunchManager(new ParallelLaunchConfigurationDelegate(), lf);
       }
}

Are you sure you want to create a new instance of ParallelLaunchConfigurationDelegate here? Can't you just pass "this"?

Greg
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev