Re: [platform-ui-dev] Are Platform UI extension dynamic?

[Sopot Cela <scela@xxxxxxxxxx>]

It looks like those tests were first disabled in the 4.2 time-frame as part of the overhaul of the platform from 3.x to 4.x. The bug is https://bugs.eclipse.org/bugs/show_bug.cgi?id=351851 and the actual commit is https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=88771cf53356ffabfbeab67c9db3ff068e2b60e5 . Probably Paul or Eric might be able to give more info as what the plan was at that time (https://bugs.eclipse.org/bugs/show_bug.cgi?id=351851#c5 provides a hint that these tests fell in the 3rd group).

As for the status now, those tests don't work at all if you enable them. They mostly fail with the line 91 of DynamicTestCase class which asserts that addition events are received. I don't think the plan was to "get rid" of the behavior, rather my guess is it broke during the transition and not enough effort was put in repairing it.

But regardless of reasons, I think there is still value in those tests in the sense that they would be a good start to validate the change in bug 484105. If they (or a modified version) pass after a fix from bug 484105 we should be able to enable them again.

Sopot

----- Oorspronkelijk bericht -----
Van: "Mickael Istria" <mistria@xxxxxxxxxx>
Aan: "Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Verzonden: Donderdag 24 december 2015 11:45:17
Onderwerp: [platform-ui-dev] Are Platform UI extension dynamic?

Hi all, 

As I'm working on https://bugs.eclipse.org/bugs/show_bug.cgi?id=484105 ,I've noticed the DynamicPluginsTestSuite which tests that most extensions in Platform UI can be handled dynamically (by dynamically I mean that the model and features get added-and-usable/removed-and-disabled on bundle resolution/uninstall). However, this TestSuite seem to have been ignored for a while. 
I could see that 10 years ago, Kim already implemented what I'm trying to do now: https://bugs.eclipse.org/bugs/show_bug.cgi?id=96600 . So I'm curious: Are those tests still supposed to work? Are Eclipse UI extensions still dynamic? Have they ever been? 
If they used to be dynamic, what was the reason for getting rid of such a nice behavior? I fail at understanding how Platform UI care-takers have allowed those tests to be turned off and this feature abandoned. 

Cheers, 
-- 
Mickael Istria 
Eclipse developer at JBoss, by Red Hat 
My blog - My Tweets 

_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/platform-ui-dev