[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [platform-ui-dev] Commit conventions
|
> While we're in the business of discussing commit comments... what good does the "Signed-off-by:" footer do? Doesn't it contain *exactly* the same information contained in the git author metadata?
This was discussed earlier, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=381105#c6 and later comments. Also https://bugs.eclipse.org/bugs/show_bug.cgi?id=411515 contains some relevant information.
Szymon
Stefan Xenos ---2015-11-18 04:56:33---Maybe I'm nit-picking but the phrase "or the change is fairly small and trivial" seems a bit subject
From: Stefan Xenos <sxenos@xxxxxxxxxx>
To: "Eclipse Platform UI component developers list." <platform-ui-dev@xxxxxxxxxxx>
Date: 2015-11-18 04:56
Subject: Re: [platform-ui-dev] Commit conventions
Sent by: platform-ui-dev-bounces@xxxxxxxxxxx
Maybe I'm nit-picking but the phrase "or the change is fairly small and trivial" seems a bit subjective for my tastes... but whether or not that is a problem depends on how people interpret it. I think we can try it and if we start seeing a majority of commits go in with no bug numbers, we should tighten up the rules and restrict the exception to just whitespace and comments.While we're in the business of discussing commit comments... what good does the "Signed-off-by:" footer do? Doesn't it contain *exactly* the same information contained in the git author metadata?I understand that the linux kernel needs them because a commit may pass through many hands before it reaches the kernel (and thereby have many Signed-off lines)... but in Eclipse, there is always only one signer per commit and that signer is always the author. Seems like we might be able to trim this boilerplate, too. - StefanOn Tue, Nov 17, 2015 at 3:19 PM Sergey Prigogin <eclipse.sprigogin@xxxxxxxxx> wrote: