[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [platform-swt-dev] Photon Font Patch
|
Yes. Try to open the PR before you start the work, not after the fact.
"Chris McKillop"
<cdm@xxxxxxx> To: <platform-swt-dev@xxxxxxxxxxx>
Sent by: cc:
platform-swt-dev-admin@ Subject: Re: [platform-swt-dev] Photon Font Patch
eclipse.org
09/18/02 04:17 PM
Please respond to
platform-swt-dev
Just to confirm. You want me to attach the patches to these bugs right?
chris
--
Chris McKillop <cdm@xxxxxxx> "The faster I go, the behinder I get."
Software Engineer, QNX -- Lewis Carroll --
http://qnx.wox.org/
----- Original Message -----
From: "Silenio Quarti" <Silenio_Quarti@xxxxxxx>
To: <platform-swt-dev@xxxxxxxxxxx>
Cc: <platform-swt-dev@xxxxxxxxxxx>
Sent: Wednesday, September 18, 2002 10:32 AM
Subject: Re: [platform-swt-dev] Photon Font Patch
> Chris,
>
> There are multiple problems with your patch. The first, is that for
legal
> reasons, posting a link to your patch is no good because the link can go
> bad or the content can change. The next problem is that although you
> claimed to be "fixing fonts", there really were multiple changes in your
> patch. To be exact, here is the list of PR's that Steve and I have
> entered on your behalf:
>
> http://bugs.eclipse.org/bugs/show_bug.cgi?id=23744
> http://bugs.eclipse.org/bugs/show_bug.cgi?id=23745
> http://bugs.eclipse.org/bugs/show_bug.cgi?id=23747
> http://bugs.eclipse.org/bugs/show_bug.cgi?id=23748
> http://bugs.eclipse.org/bugs/show_bug.cgi?id=23749
> http://bugs.eclipse.org/bugs/show_bug.cgi?id=23751
> http://bugs.eclipse.org/bugs/show_bug.cgi?id=23753
> http://bugs.eclipse.org/bugs/show_bug.cgi?id=23754
> http://bugs.eclipse.org/bugs/show_bug.cgi?id=23755
>
> Submitting a huge pile of code, with multiple changes and not much
> discussion of why the changes are being made is a recipe for disaster.
For
> one thing, a small patch with an associated PR not only captures the
> discussion of why the change is being made, it also allows the change to
> be prioritize, tracked and makes it easier to understand the code.
>
> In future, can you please enter PR's for each separate issue. Attach the
> patches and discussion to the bug reports.
>
> Thanks,
>
> Steve and Silenio
>
>
>
>
>
> "Chris McKillop" <cdm@xxxxxxx>
> Sent by: platform-swt-dev-admin@xxxxxxxxxxx
> 09/18/02 08:00 AM
> Please respond to platform-swt-dev
>
>
> To: <platform-swt-dev@xxxxxxxxxxx>
> cc:
> Subject: [platform-swt-dev] Photon Font Patch
>
>
> http://qnx.wox.org/swt/swt.fonts.patch
>
> This is to bring the SWT more into line with how it should look on
Photon.
> The org.eclipse.ui plugin has also recently been updated to include
> similar
> changes. However, due to the nature of things both it and the SWT need
to
> be kept in sync.
>
> No new natives or anything - just a change to how Display.getSystemFont()
> is
> picked and forcing certain widgets to use this font instead of the
default
> libph font. Unfortunately, since the photon widget set does not
currently
> include a layout management system we cannot change the default fonts
> inside
> of libph or we will break existing applications.
>
> This patch also includes the change to the look-n-feel of the Group
> widget.
>
> I have not entered a bugzilla entry for this yet since it really isn't a
> "bug" per-se but more a case of continuing development. Please let me
> know
> your thoughts, comments, etc.
>
> chris
>
> --
> Chris McKillop <cdm@xxxxxxx> "The faster I go, the behinder I get."
> Software Engineer, QNX -- Lewis Carroll --
> http://qnx.wox.org/
>
>
> _______________________________________________
> platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>
>
>
> _______________________________________________
> platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>
_______________________________________________
platform-swt-dev mailing list
platform-swt-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-swt-dev