[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [platform-releng-dev] [eclipse-build]Build N20060304-0010 (Timestamp: 200603040010):Automated JUnit testing complete. Test failures/errors occurred.
|
> org.eclipse.releng.tests_linux.gtk.x86
> org.eclipse.releng.tests_macosx.carbon.ppc
> org.eclipse.releng.tests_win32.win32.x86
A new patch for swt that should also fix the warnings reported during the
builds.
Fixes:
- unused imports,
- unnecessary semi-colon
- empty flow statement
- unread field (private fields)
- javadoc warnings
*_j2me configurations need to be fixed as well.
Olivier
### Eclipse Workspace Patch 1.0
#P org.eclipse.swt
Index: Eclipse SWT/emulated/tooltip/org/eclipse/swt/widgets/ToolTip.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/emulated/tooltip/org/eclipse/swt/widgets/ToolTip.java,v
retrieving revision 1.2
diff -u -r1.2 ToolTip.java
--- Eclipse SWT/emulated/tooltip/org/eclipse/swt/widgets/ToolTip.java 3 Mar 2006 21:42:56 -0000 1.2
+++ Eclipse SWT/emulated/tooltip/org/eclipse/swt/widgets/ToolTip.java 4 Mar 2006 19:12:43 -0000
@@ -173,11 +173,11 @@
int textWidth = 0, messageWidth = 0;
if (layoutText != null) {
layoutText.setWidth (-1);
- textWidth = layoutText.getBounds ().width;;
+ textWidth = layoutText.getBounds ().width;
}
if (layoutMessage != null) {
layoutMessage.setWidth (-1);
- messageWidth = layoutMessage.getBounds ().width;;
+ messageWidth = layoutMessage.getBounds ().width;
}
int messageTrim = 2 * INSET + 2 * BORDER + 2 * PADDING;
boolean hasImage = layoutText != null && (style & SWT.BALLOON) != 0 && (style & (SWT.ICON_ERROR | SWT.ICON_INFORMATION | SWT.ICON_WARNING)) != 0;
Index: Eclipse SWT/win32/org/eclipse/swt/widgets/ExpandBar.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ExpandBar.java,v
retrieving revision 1.8
diff -u -r1.8 ExpandBar.java
--- Eclipse SWT/win32/org/eclipse/swt/widgets/ExpandBar.java 28 Feb 2006 23:30:09 -0000 1.8
+++ Eclipse SWT/win32/org/eclipse/swt/widgets/ExpandBar.java 4 Mar 2006 19:12:46 -0000
@@ -396,7 +396,7 @@
info.cbSize = SCROLLINFO.sizeof;
info.fMask = OS.SIF_RANGE | OS.SIF_PAGE | OS.SIF_POS;
info.nMin = 0;
- info.nMax = maxHeight;;
+ info.nMax = maxHeight;
info.nPage = height;
info.nPos = Math.min (yCurrentScroll, info.nMax);
if (info.nPage != 0) info.nPage++;
Index: Eclipse SWT/win32/org/eclipse/swt/widgets/ToolTip.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/ToolTip.java,v
retrieving revision 1.5
diff -u -r1.5 ToolTip.java
--- Eclipse SWT/win32/org/eclipse/swt/widgets/ToolTip.java 3 Mar 2006 21:16:07 -0000 1.5
+++ Eclipse SWT/win32/org/eclipse/swt/widgets/ToolTip.java 4 Mar 2006 19:12:48 -0000
@@ -66,9 +66,9 @@
* <li>ERROR_INVALID_SUBCLASS - if this class is not an allowed subclass</li>
* </ul>
*
- * @see SWT#ERROR
- * @see SWT#INFORMATION
- * @see SWT#WARNING
+ * @see SWT#ICON_ERROR
+ * @see SWT#ICON_INFORMATION
+ * @see SWT#ICON_WARNING
* @see Widget#checkSubclass
* @see Widget#getStyle
*/
Index: Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java,v
retrieving revision 1.306
diff -u -r1.306 Table.java
--- Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java 2 Mar 2006 20:39:08 -0000 1.306
+++ Eclipse SWT/win32/org/eclipse/swt/widgets/Table.java 4 Mar 2006 19:12:48 -0000
@@ -1490,7 +1490,7 @@
TOOLINFO lpti = new TOOLINFO ();
lpti.cbSize = TOOLINFO.sizeof;
lpti.uId = column.id;
- lpti.hwnd = OS.SendMessage (handle, OS.LVM_GETHEADER, 0, 0);;
+ lpti.hwnd = OS.SendMessage (handle, OS.LVM_GETHEADER, 0, 0);
OS.SendMessage (headerToolTipHandle, OS.TTM_DELTOOL, 0, lpti);
}
}
Index: Eclipse SWT/win32/org/eclipse/swt/widgets/TrayItem.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/TrayItem.java,v
retrieving revision 1.23
diff -u -r1.23 TrayItem.java
--- Eclipse SWT/win32/org/eclipse/swt/widgets/TrayItem.java 3 Mar 2006 22:42:16 -0000 1.23
+++ Eclipse SWT/win32/org/eclipse/swt/widgets/TrayItem.java 4 Mar 2006 19:12:48 -0000
@@ -262,7 +262,7 @@
if (isDisposed()) return 0;
}
}
- };
+ }
break;
}
display.wakeThread ();
Index: Eclipse SWT Drag and Drop/motif/org/eclipse/swt/dnd/DropTarget.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT Drag and Drop/motif/org/eclipse/swt/dnd/DropTarget.java,v
retrieving revision 1.44
diff -u -r1.44 DropTarget.java
--- Eclipse SWT Drag and Drop/motif/org/eclipse/swt/dnd/DropTarget.java 8 Feb 2006 20:01:03 -0000 1.44
+++ Eclipse SWT Drag and Drop/motif/org/eclipse/swt/dnd/DropTarget.java 4 Mar 2006 19:12:42 -0000
@@ -13,7 +13,6 @@
import org.eclipse.swt.*;
import org.eclipse.swt.widgets.*;
-import org.eclipse.swt.graphics.*;
import org.eclipse.swt.internal.Callback;
import org.eclipse.swt.internal.motif.*;
Index: Eclipse SWT Drag and Drop/win32/org/eclipse/swt/dnd/StyledTextDragAndDropEffect.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT Drag and Drop/win32/org/eclipse/swt/dnd/StyledTextDragAndDropEffect.java,v
retrieving revision 1.4
diff -u -r1.4 StyledTextDragAndDropEffect.java
--- Eclipse SWT Drag and Drop/win32/org/eclipse/swt/dnd/StyledTextDragAndDropEffect.java 2 Mar 2006 18:23:16 -0000 1.4
+++ Eclipse SWT Drag and Drop/win32/org/eclipse/swt/dnd/StyledTextDragAndDropEffect.java 4 Mar 2006 19:12:42 -0000
@@ -13,7 +13,6 @@
import org.eclipse.swt.custom.*;
import org.eclipse.swt.graphics.*;
-import org.eclipse.swt.widgets.*;
import org.eclipse.swt.internal.win32.*;
class StyledTextDragAndDropEffect extends DragAndDropEffect {
Index: Eclipse SWT Printing/motif/org/eclipse/swt/printing/Printer.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT Printing/motif/org/eclipse/swt/printing/Printer.java,v
retrieving revision 1.31
diff -u -r1.31 Printer.java
--- Eclipse SWT Printing/motif/org/eclipse/swt/printing/Printer.java 23 Jun 2005 14:51:56 -0000 1.31
+++ Eclipse SWT Printing/motif/org/eclipse/swt/printing/Printer.java 4 Mar 2006 19:12:42 -0000
@@ -220,7 +220,7 @@
while (i < buffer2.length) {
if (buffer2[i] != ' ') {
int start = i;
- while (++i < buffer2.length && buffer2[i] != ' ');
+ while (++i < buffer2.length && buffer2[i] != ' ') {/*empty*/}
String server = new String(buffer2, start, i - start);
String[] newServerList = new String[serversList.length + 1];
System.arraycopy(serversList, 0, newServerList, 0, serversList.length);
Index: Eclipse SWT/photon/org/eclipse/swt/widgets/Widget.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/photon/org/eclipse/swt/widgets/Widget.java,v
retrieving revision 1.58
diff -u -r1.58 Widget.java
--- Eclipse SWT/photon/org/eclipse/swt/widgets/Widget.java 11 Aug 2005 23:15:34 -0000 1.58
+++ Eclipse SWT/photon/org/eclipse/swt/widgets/Widget.java 4 Mar 2006 19:12:46 -0000
@@ -551,7 +551,7 @@
String getName () {
String string = getClass ().getName ();
int index = string.length ();
- while (--index > 0 && string.charAt (index) != '.');
+ while (--index > 0 && string.charAt (index) != '.') {/* empty */}
return string.substring (index + 1, string.length ());
}
Index: Eclipse SWT Drag and Drop/photon/org/eclipse/swt/dnd/TreeDragAndDropEffect.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT Drag and Drop/photon/org/eclipse/swt/dnd/TreeDragAndDropEffect.java,v
retrieving revision 1.1
diff -u -r1.1 TreeDragAndDropEffect.java
--- Eclipse SWT Drag and Drop/photon/org/eclipse/swt/dnd/TreeDragAndDropEffect.java 8 Feb 2006 20:27:08 -0000 1.1
+++ Eclipse SWT Drag and Drop/photon/org/eclipse/swt/dnd/TreeDragAndDropEffect.java 4 Mar 2006 19:12:42 -0000
@@ -17,9 +17,6 @@
class TreeDragAndDropEffect extends DragAndDropEffect {
private Tree tree;
- private TreeItem currentItem = null;
- private int currentEffect = DND.FEEDBACK_NONE;
- private TreeItem[] selection = new TreeItem[0];
TreeDragAndDropEffect(Tree tree) {
this.tree = tree;
Index: Eclipse SWT/motif/org/eclipse/swt/widgets/Display.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/motif/org/eclipse/swt/widgets/Display.java,v
retrieving revision 1.192
diff -u -r1.192 Display.java
--- Eclipse SWT/motif/org/eclipse/swt/widgets/Display.java 22 Jun 2005 23:25:21 -0000 1.192
+++ Eclipse SWT/motif/org/eclipse/swt/widgets/Display.java 4 Mar 2006 19:12:45 -0000
@@ -3609,11 +3609,11 @@
}
void wakeThread () {
/* Write a single byte to the wake up pipe */
- while (OS.write (write_fd, wake_buffer, 1) != 1);
+ while (OS.write (write_fd, wake_buffer, 1) != 1) {/* empty */}
}
int wakeProc (int closure, int source, int id) {
/* Read a single byte from the wake up pipe */
- while (OS.read (read_fd, wake_buffer, 1) != 1);
+ while (OS.read (read_fd, wake_buffer, 1) != 1) {/* empty */}
return 0;
}
static int wcsToMbcs (char ch) {
Index: Eclipse SWT/motif/org/eclipse/swt/widgets/Spinner.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/motif/org/eclipse/swt/widgets/Spinner.java,v
retrieving revision 1.21
diff -u -r1.21 Spinner.java
--- Eclipse SWT/motif/org/eclipse/swt/widgets/Spinner.java 3 Mar 2006 19:02:52 -0000 1.21
+++ Eclipse SWT/motif/org/eclipse/swt/widgets/Spinner.java 4 Mar 2006 19:12:45 -0000
@@ -564,7 +564,7 @@
int textHeight = Math.max (height - 2 * argList1 [7], 0);
if (textWidth != argList2 [1] || textHeight != argList2 [3]) {
OS.XtResizeWidget (argList1 [1], textWidth, textHeight, argList2 [5]);
- };
+ }
}
return super.setBounds (x, y, width, height, move, resize);
}
Index: Eclipse SWT/carbon/org/eclipse/swt/widgets/TreeColumn.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/carbon/org/eclipse/swt/widgets/TreeColumn.java,v
retrieving revision 1.13
diff -u -r1.13 TreeColumn.java
--- Eclipse SWT/carbon/org/eclipse/swt/widgets/TreeColumn.java 26 Oct 2005 19:46:49 -0000 1.13
+++ Eclipse SWT/carbon/org/eclipse/swt/widgets/TreeColumn.java 4 Mar 2006 19:12:43 -0000
@@ -326,7 +326,7 @@
int calculateWidth (int[] ids, int index, GC gc, int width) {
if (ids == null) return width;
for (int i=0; i<ids.length; i++) {
- TreeItem item = parent._getItem (ids [i], false);;
+ TreeItem item = parent._getItem (ids [i], false);
if (item != null) {
width = Math.max (width, item.calculateWidth (index, gc));
if (item.getExpanded ()) {
Index: Eclipse SWT/carbon/org/eclipse/swt/widgets/MenuItem.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/carbon/org/eclipse/swt/widgets/MenuItem.java,v
retrieving revision 1.55
diff -u -r1.55 MenuItem.java
--- Eclipse SWT/carbon/org/eclipse/swt/widgets/MenuItem.java 26 Oct 2005 19:06:33 -0000 1.55
+++ Eclipse SWT/carbon/org/eclipse/swt/widgets/MenuItem.java 4 Mar 2006 19:12:43 -0000
@@ -261,7 +261,7 @@
int outMenuRef [] = new int [1];
if (OS.GetMenuItemHierarchicalMenu (menu.handle, (short)(index + 1), outMenuRef) != OS.noErr) {
return new Rectangle (0 ,0, 0, 0);
- };
+ }
Rect rect = new Rect ();
//TODO - get the bounds of the menu item from the menu title
// if (... code needed to do this ... != OS.noErr) {
Index: Eclipse SWT/carbon/org/eclipse/swt/widgets/ToolTip.java
===================================================================
RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/carbon/org/eclipse/swt/widgets/ToolTip.java,v
retrieving revision 1.3
diff -u -r1.3 ToolTip.java
--- Eclipse SWT/carbon/org/eclipse/swt/widgets/ToolTip.java 3 Mar 2006 21:46:43 -0000 1.3
+++ Eclipse SWT/carbon/org/eclipse/swt/widgets/ToolTip.java 4 Mar 2006 19:12:43 -0000
@@ -162,11 +162,11 @@
int textWidth = 0, messageWidth = 0;
if (layoutText != null) {
layoutText.setWidth (-1);
- textWidth = layoutText.getBounds ().width;;
+ textWidth = layoutText.getBounds ().width;
}
if (layoutMessage != null) {
layoutMessage.setWidth (-1);
- messageWidth = layoutMessage.getBounds ().width;;
+ messageWidth = layoutMessage.getBounds ().width;
}
int messageTrim = 2 * INSET + 2 * BORDER + 2 * PADDING;
boolean hasImage = layoutText != null && (style & SWT.BALLOON) != 0 && (style & (SWT.ICON_ERROR | SWT.ICON_INFORMATION | SWT.ICON_WARNING)) != 0;
