Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-releng-dev] [eclipse-build]Build N20060127-0010 (Timestamp: 200601270010):Compile errors in build

Yes, they can be accessed via views as well.  Having "workbench part" in 
the name might be a bit confusing because although the model/document(s) 
are accessed via workbench parts, they're not tied to a particular part.
The concept is somewhat similar to the document/view architecture in MFC, 
but with support for a single view (or editor) managing multiple 
documents, in addition to having the documents possibly shared between 
parts.

Nick




Daniel Megert <daniel_megert@xxxxxxxxxx> 
Sent by: platform-releng-dev-bounces@xxxxxxxxxxx
01/27/2006 10:42 AM
Please respond to
"Eclipse platform release engineering list."


To
"Eclipse platform release engineering list." 
<platform-releng-dev@xxxxxxxxxxx>
cc

Subject
Re: [platform-releng-dev]       [eclipse-build]Build    N20060127-0010 
(Timestamp:     200601270010):Compile errors in build






I wouldn't call it editor model since I guess it might also be used by 
view
parts. What about I(Workbench)PartModel, since you add this to a UI layer?

Dani


 
             Nick Edgar 
             <Nick_Edgar@xxxxx 
             m.com>                                                     To 

             Sent by:                  "Eclipse platform release 
             platform-releng-d         engineering list." 
             ev-bounces@eclips         <platform-releng-dev@xxxxxxxxxxx> 
             e.org                                                      cc 

 
                                                                   Subject 

             27.01.2006 16:33          Re: [platform-releng-dev] 
                                       [eclipse-build]Build 
                                       N20060127-0010    (Timestamp: 
             Please respond to         200601270010):Compile errors in 
             "Eclipse platform         build 
                  release 
                engineering 
                  list." 
             <platform-releng- 
             dev@xxxxxxxxxxx> 
 
 




Doug suggested
+ IModel
+ ISavableModel
+ IModelWithHandlers
+ IEditorModel
+ IEditableModel

I'm tending toward ISaveableModel (the new supprot works with
ISaveablePart).

Nick




Michael Valenta/Ottawa/IBM@IBMCA
Sent by: platform-releng-dev-bounces@xxxxxxxxxxx
01/27/2006 10:17 AM
Please respond to
"Eclipse platform release engineering list."


To
"Eclipse platform release engineering list."
<platform-releng-dev@xxxxxxxxxxx>
cc

Subject
Re: [platform-releng-dev]       [eclipse-build]Build    N20060127-0010
(Timestamp:     200601270010):Compile errors in build







Nick,

John and I batted around a few names and some possibilites are IBuffer (a
generalization of a file buffer), ISavable or ISavableBuffer. You could
also go with ISavableDocument but that would indicate a link to the
existing IDocument which is strickly text based.

Michael



Nick Edgar/Ottawa/IBM@IBMCA
Sent by: platform-releng-dev-bounces@xxxxxxxxxxx
01/27/2006 10:09 AM

Please respond to
"Eclipse platform release engineering list."


To
"Eclipse platform release engineering list."
<platform-releng-dev@xxxxxxxxxxx>
cc

Subject
Re: [platform-releng-dev]        [eclipse-build]Build N20060127-0010
(Timestamp:        200601270010):Compile errors in build








Sorry, I should have given a heads-up about this possibility.  I admit
that the name overloading is not ideal, but I was having difficulty coming

up with a better name.
Here is the Javadoc for it:

/**
* An <code>IDocument</code> represents an editable subset of the domain
* model. Different workbench parts (editors and views) may present the
same
* document in different ways. This interface allows the workbench to
provide
* more appropriate handling of operations such as saving and closing
workbench
* parts. For example, if two editors sharing the same document with
unsaved
* changes are closed simultaneously, the user is only prompted to save
the
* changes once for the shared document, rather than once for each editor.
* <p>
* Workbench parts that work in terms of documents should implement
* {@link IDocumentSource}.
* </p>
*
* @see IDocumentSource
* @since 3.2
*/

I considered IModel, but that it doesn't necessarily represent the whole
domain model, just some editable portion of it.
I also didn't want it to be confused with the new notion of model provider

in core.resources.

Any suggestions?

Nick




Daniel Megert <daniel_megert@xxxxxxxxxx>
Sent by: platform-releng-dev-bounces@xxxxxxxxxxx
01/27/2006 03:28 AM
Please respond to
"Eclipse platform release engineering list."


To
"Eclipse platform release engineering list."
<platform-releng-dev@xxxxxxxxxxx>
cc

Subject
Re: [platform-releng-dev]       [eclipse-build]Build    N20060127-0010
(Timestamp: 200601270010):Compile       errors in build






Note, the new IDocument was not introduced by Platform Text. I see that
this will not break binary compatibility but it might still be confusing
for clients. Could the inventor eventually use a different name?

Thanks,
Dani



            Wassim Melhem
            <wassimm@xxxxxx.c
            om>                                                        To

            Sent by:                  "Eclipse platform release
            platform-releng-d         engineering list."
            ev-bounces@eclips         <platform-releng-dev@xxxxxxxxxxx>
            e.org                                                      cc


                                                                  Subject

            27.01.2006 08:37          Re: [platform-releng-dev]
                                      [eclipse-build]Build
                                      N20060127-0010    (Timestamp:
            Please respond to         200601270010):Compile errors in
            "Eclipse platform         build
                 release
               engineering
                 list."
            <platform-releng-
            dev@xxxxxxxxxxx>






Apparently, a new type named IDocument was invented yesterday causing
ambiguity when using import statements such as org.eclipse.jface.text.* in
our code.

Fixed the compiler errors in PDE/UI by reorganizing our imports.

Wassim.






            eclipse-releng@ec
            lipse.org
            Sent by:                                                   To
            platform-releng-d         platform-releng-dev@xxxxxxxxxxx
            ev-bounces@eclips                                          cc
            e.org
                                                                  Subject
                                      [platform-releng-dev]
            01/27/2006 02:15          [eclipse-build]Build N20060127-0010
            AM                        (Timestamp: 200601270010):Compile
                                      errors in build

            Please respond to
            "Eclipse platform
                 release
               engineering
                 list."






Build N20060127-0010 (Timestamp: 200601270010):  Compile errors in build.
See attached compile logs.[attachment
"/builds/transfer/files/master/downloads/drops/N20060127-0010/compilelogs/plugins/org.eclipse.ui.intro_3.2.0.N20060127-0010/@dot.bin.log"


deleted by Wassim Melhem/Toronto/IBM] [attachment
"/builds/transfer/files/master/downloads/drops/N20060127-0010/compilelogs/plugins/org.eclipse.jdt.launching.macosx_3.1.100.N20060127-0010/@dot.bin.log"


deleted by Wassim Melhem/Toronto/IBM] [attachment
"/builds/transfer/files/master/downloads/drops/N20060127-0010/compilelogs/plugins/org.eclipse.pde.ui_3.2.0.N20060127-0010/@dot.bin.log"


deleted by Wassim Melhem/Toronto/IBM] [attachment
"/builds/transfer/files/master/downloads/drops/N20060127-0010/compilelogs/plugins/org.eclipse.team.cvs.ui_3.2.0.N20060127-0010/@dot.bin.log"


deleted by Wassim Melhem/Toronto/IBM] [attachment
"/builds/transfer/files/master/downloads/drops/N20060127-0010/compilelogs/plugins/org.eclipse.jdt.ui.tests.refactoring_3.1.0


/refactoringtests.jar.bin.log" deleted by Wassim Melhem/Toronto/IBM]
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev


_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev


_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev


_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev


_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev


_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev




Back to the top