Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-dev] Recent API Removal breaks clients

I have filed a couple of bugs. Amongst which:

* Bug 567200 - Only remove API one time a year
* Bug 567203 - Require reason and impact assessment for API removal

The umbrella bug is here.

Bug 567195 - Optimize the API removal process 

Cheers, Wim


On Thu, Sep 17, 2020 at 9:05 PM Wim Jongman <wim.jongman@xxxxxxxxx> wrote:
Hi,

jface.util.Assert was removed as well as platform.getJobManager.

I love the cleanup but I hate the panic that this causes. I take care of WindowBuilder and Nebula releng. We do not build against the development version but against an older version. This is to protect us to not accidentally use a new API that is not compatible with the oldest Eclipse we support. This means that the build completes normally.

Should we not support older versions of Eclipse?

So now we have the removal of jface.util.Assert which breaks WindowBuilder. I did not see it because I did not use WB after Assert was removed only six weeks ago (over the holidays). Now the reports flow in because people are upgrading and we are no longer compatible with the latest eclipse.

I suggest adding three things to the API removal process.

1. The person that proposes the API change makes an impact analysis by searching all the Eclipse repositories, removal is abandoned if used > x%
2. Removal of API is sent to the mailing list of the project that uses the API so that we can fix things in time, especially when the project is in maintenance mode.
3. API's are only removed before M1. This gives us some more time to catch and fix.

Cheers,

Wim

* As an added bonus I now also have to deal with the removal of platform.getJobManager that break the IBM rational plugins that we use for our product. Now I have to chase IBM to fix something, I'd rather be fighting windmills.




Back to the top