Re: [platform-dev] ArrayList vs Vector

[Thomas Singer <ts-swt@xxxxxxxxxxx>]

Hi Andrey and all,

Then this would require a deep thought about which method is allowed to 
be executed in a non-event-dispatch thread. I would assume that any 
method of SWT except of display.asyncExec is not thread-safe and only is 
allowed to be executed from the event-dispatch thread. Maybe my 
assumption is wrong?

--
Best regards,
Thomas Singer
=============
syntevo GmbH
www.syntevo.com


On 2020-01-20 12:15, Andrey Loskutov wrote:
> Hi all,
>
> There is a series of commits that are replacing Vector with ArrayList with the reasoning "Vector is an outdated data structure and ArrayList should be preferred
> as it is faster".
>
> Please note, that Vector is synchronized and ArrayList not, so this is not 1:1 "no-op" exchange!
>
> As javadoc in Vector says, one could replace it with ArrayList, but only "If a thread-safe implementation is not needed".
>
> So whoever is going to review & merge this, please make sure you have understood the implication of the change on internal & external behavior of the changed code.
>
> https://git.eclipse.org/r/156169
> https://git.eclipse.org/r/156179
> https://git.eclipse.org/r/156172
> https://git.eclipse.org/r/156170
> https://git.eclipse.org/r/156166
> https://git.eclipse.org/r/156167
> https://git.eclipse.org/r/156168
> https://git.eclipse.org/r/156171
>
> Kind regards,
> Andrey Loskutov
>
> Спасение утопающих - дело рук самих утопающих
>
> https://www.eclipse.org/user/aloskutov
>
> _______________________________________________
> platform-dev mailing list
> platform-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/platform-dev