It's really good that we have this discussion on quality.
I added 5.0.1 version in Bugzilla and PMI. Planned release date is
June 28 - to coincide with the official Oxygen release. It won't be
part of the PHP EPP, but everyone would be able to update to 5.0.1
at the same date.
Unfortunately, the 5.0.1 update won't be automatically suggested by
the PHP EPP, but users will need to manually add the respective
update site. This is a point for improvement in the PHP EPP for the
Oxygen.1 release.
So, let's try the suggested "add code that is at least reviewed by 2
members" rule for this 5.0.1 release. Technically, all fixes should
be first committed in master for the next feature release (today
this is 5.1). Then we can cherry-pick the voted fixes into the
maintenance branch (today this is stable-5.0).
Voting for cherry-picking can happen in Bugzilla. We can use the
review flag. Here is how I did it in the first candidate for 5.0.1:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=516350. A positive
review should include actual testing.
On 06/16/2017 03:43 PM, thierry blind
wrote:
For the " add code
that is at least reviewed by 2 members", it's of course for
code after RC1 for example ;)
I'll add another point about those 2 patches: they
basically tried to fix long-standing problems in class
ASTProvider.
But some stacktraces before and after those patches look
mostly the same, so main problems are still here.
And it is even worse now!
This class always had bugs, and it's not well-written (sorry
to say that, complex code doesn't always mean good code), it's
a real blackbox and a hell to debug.
My conclusion is simple here: we should rewrite it to feat
our needs, more simpler, with more debug traces, and ideally
with understandable locking-system!
As first step, no need to be optimal code, just "working
code" ;)
I would put that as top
priority for 5.1, since Alex adds more and more (great)
features to PDT that seem to depend on correct ASTProvider
behavior ;)
But that's just my opinion...
Sorry Kaloyan, I mean patches
https://git.eclipse.org/r/#/c/96253/ and https://git.eclipse.org/r/#/c/99102/ !
Yes it would be great to have some opinions from all team
about using the 5.0 release, to see if we should revert
those 2 patches. Opinions should only concern "writing PHP
code using the PHP editor" ;)
Personally I find it less good now, because
you have validation " artifacts" and
highlighting problems while coding. I don't say these
problems are new, but they happen much more often now! I
consider that as a regression.
And totally agree for your last point, maybe we
should even stop adding code earlier (before RC1), or
add code that is at least reviewed by 2 members (other
than the patch creator) for example. In the case of
these 2 patches, time was too short to fully review
them, even if first patch was created beginning may.
Thierry.
Hi Thierry,
As far as I can see
https://git.eclipse.org/r/#/c/99312/ was
just merged in master, i.e. it goes to
5.1-nightly, but not to 5.0.
|
git.eclipse.org
Loading Gerrit Code Review... ...
Home; Privacy Policy; Terms of Use;
Copyright Agent; Legal
|
So, it is only
https://git.eclipse.org/r/#/c/99102/ (the
patch that we included in RC4) that actually
worries you for PDT 5.0, right?
|
git.eclipse.org
Loading Gerrit Code Review... ...
Home; Privacy Policy; Terms of Use;
Copyright Agent; Legal
|
BTW, you can download the final PHP EPP build from
here:
https://hudson.eclipse.org/packaging/job/oxygen.epp-tycho-build/318/artifact/org.eclipse.epp.packages/archive/
I suggest all of us do it and see if we are really
happy with the result. If we still want to fix
anything until the official release date (June 28)
then I suggest that we target a 5.0.1 maintenance
release at this date.
I think it is also a good idea to be more careful
during the RC phase of future releases. Perhaps,
we can now build some good process of what goes
into 5.0.1 and then reuse it for the RC phase of
future releases.
Kaloyan Raev |
Zend Studio Team Lead
Rogue Wave
Software, Inc.
Innovate with Confidence
M +359 887 648
663
www.roguewave.com
/
kaloyan.raev@xxxxxxxxxxxxx
|
We’re the largest independent
provider of cross-platform software
development tools and embedded
components in the world. Come see
how we can help.
|
On 06/16/2017 11:28
AM, thierry blind wrote:
While speaking about bugs, would it be
possible to revert somehow patches
https://git.eclipse.org/r/#/c/99312/
and https://git.eclipse.org/r/#/c/99102/ ?
I know I come (too) late for 5.0, but maybe
for a 5.0.1 release?
With more testing, they break things more
than they solved in the PHP editor, for
example:
- compilation errors do not always
disappear (annotations seem to be "stuck")
- variable highlighting stop to work
pretty fastly
- unused variable highlighting
(from the PDT extensions) also stop to
work pretty fastly
Only easy fix I found is to switch
between editor tabs, it reset things
afterwards (but problem will appear again).
I think more and more we should have
never merged these ones (we should have
tested these patches much more, I was also
too confident this time), but it's a bit
too late to
whine and complain about that
;)
I'm worried about what the PDT users
experience, we added so many great
features, but the main component (the PHP
editor) is now feeling more clumsy, I'm a
bit sad about sad :( Because it can upset users
and make them go away from PDT.
Thierry.
Try older PHP version, 5.6 or 7.0.
I think there is bug with latest 7.1
Greetings,
Michał Niewrzał | ZEND
STUDIO
Rogue Wave
Software, Inc.
Accelerating
Great Code
www.roguewave.com /
michal.niewrzal@roguewave.com
I will rework, If you let me know
how to make the Trace Failure appear
:-)
It just does not work for me in PDT.
On
06/15/2017 05:29 PM, Bartłomiej
Łączkowski wrote:
|
This sender failed our fraud detection checks and may not be who they appear to be. Learn about spoofing |
Feedback |
Cool :) I think that it would
be nice to have one failing test
in PHPUnit view selected to see
some failure trace in "Failure
Trace" pane.
On
6/15/2017 4:13 PM, Kaloyan Raev
wrote:
How about
this?
Screenshot: attached
Headline: Test Code and Manage
Dependencies with PHP
Development Tools
Details: The PHP support in
Eclipse improved by adding
integration with PHPUnit for
testing PHP code, and with
Composer for managing PHP
dependencies.
On
06/15/2017 02:00 PM, Dawid
Pakuła wrote:
I think
both, composer editor plus
phpunit after test run ;) Both
with project explorer.
On 15
June 2017 at 10:27:27,
Kaloyan Raev (kaloyan.r@xxxxxxxx)
wrote:
Thanks, Thierry!
Any other opinions?
If we should pick
between Composer and
PHPUnit, what would be
your choice?
On
06/14/2017 12:14 PM,
thierry blind wrote:
Even so, what
feature should
we highlight?
What would a PHP
developer like
the most in PDT
5.0? :) What is
exclusive to PDT
you don't find
in other IDE
yet?
Globally
debugging&testing
is more powerful
in PDT yet.
PHP profiling
is also a great
new feature, but
only for Zend
debugger (and
I'm using Xdebug
"sadly").
Supporting composer
projects is also
a big step.
Hard to choose,
maybe we should
do some vote
here ;)
True, it's
impossible to
have all new
features and
improvements
in a single
screenshot. I
think the idea
is to
highlight one
new thing that
would
encourage
people to try
PDT 5.0 (or
Eclipse Oxygen
in general).
We have an
article, a
webinar
and
a N&N page
to cover all
the rest.
For example,
if you look at
https://www.eclipse.org/oxygen/, JDT are promoting an improvement in
the debugger.
|
|
Eclipse
is probably
best known as
a Java IDE,
but it is
more: it is an
IDE framework,
a tools
framework, an
open source
project, a
community, an
eco-system,
and a
foundation.
|
On
06/14/2017
11:44 AM,
thierry blind
wrote:
Hi Kaloyan,
that's not
an easy task
:)
if
you can do a
screenshot
for a php composer projet with an opened php 7.1 file
having PHP
syntax check
and validation
errors, with a
PHPUnit tab, a Built-in
PHP Server
tab, or some
PHP profiling
tabs, you'll
show some nice
new features
:)
Thierry.
Hi Team,
We have a
request by the
Eclipse
Marketing to
provide one
screenshot of
PDT 5.0 for
the Oxygen
page.
We have many
new features
and
improvements
in PDT 5.0.
How would the
single
screenshot
look like? Any
ideas?
Thanks,
Kaloyan
--------
Forwarded
Message
--------
Hi
Kaloyan,
I hope
all is well
with you!
We are in
the midst of
preparing the
eclipse.org/oxygen web page for
June 28, and
we were
wondering if
you'd be able
to assist with
a cool
screenshot of
PDT 5.0 in
Oxygen that we
could add to
the screenshot
section on the
web page!
We'd need
a crisp high
resolution
screen shot,
with a short
description of
what you're
showing us,
and a header.
Is this
something you
could provide
in the next
day or so?
Take a look at
the site for
examples, and
let me know if
you have
questions.
Thank
you!
_______________________________________________
pdt-dev mailing list
pdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pdt-dev
_______________________________________________
pdt-dev mailing list
pdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pdt-dev
_______________________________________________
pdt-dev mailing list
pdt-dev@xxxxxxxxxxx
To change your
delivery options,
retrieve your
password, or
unsubscribe from this
list, visit
https://dev.eclipse.org/mailman/listinfo/pdt-dev
_______________________________________________
pdt-dev mailing list
pdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pdt-dev
_______________________________________________
pdt-dev mailing list
pdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pdt-dev
_______________________________________________
pdt-dev mailing list
pdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pdt-dev
_______________________________________________
pdt-dev mailing list
pdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pdt-dev
_______________________________________________
pdt-dev mailing list
pdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pdt-dev
|
