Re: [pde-dev] PDE and GitHub

[Christoph Läubrich <laeubi@xxxxxxxxxxxxxx>]

Hi Vikas,

>  I am happy to see PDE as one of the most active repos these days.

Maybe because of

> few things are missing post migration to GitHub.

so people are not forced to invest time to so many management stuff and 
instead have time for coding?

> It is recommended that all non-trivial changes should have a 
corresponding issue

It is already recommended to write detailed commit messages, I found 
that replaces creating an issue first, as no one reading the issues 
anyways (personal opinion) so I better write it at the commit/PR 
directly :-)

> All PRs without an issue should compulsorily  have “milestone” and 
“assignee” set in the PR.

I think doing so only makes sense if we having many Milestones in 
parallel, otherwise Milestone = current release.

e.g. at Tycho I simply mark all issues closed with the current milestone 
using a filter, and only assign dedicated ones in case of backporting to 
older releases.

@Lars
> we could use git shortlog milestoneref1 milestoneref2 t

I think we should use as much automation as possible, there is even 
GithubCLI to automate stuff via custom scripts and man actions, tools 
and applications that could save us these times to handle it manually!

Am 15.07.22 um 12:46 schrieb Lars Vogel:
> -1 from me for the requirement to create an issue. PR and issues are
> basically the same, so we could not gain anything by having the
> requirement to create one.
>
> I don't mind using milestone tags but also do not see value in this,
> we could use git shortlog milestoneref1 milestoneref2 to get the
> commits.
>
>
> On Thu, Jul 14, 2022 at 5:53 AM Vikas Chandra <Vikas.Chandra@xxxxxxxxxx> wrote:
> > Hello PDE committers and contributors,
> >
> >
> >
> > Thanks for all your contributions/commits. I am happy to see PDE as one of the most active repos these days. However
> >
> > few things are missing post migration to GitHub.
> >
> >
> >
> > Ever since we have moved to GitHub, we are missing some of the old actions that helped in better testing, bug tracking, finding
> >
> > commits that causes issue etc, identifying nice features and bugs in a milestone or over last few weeks.
> >
> >
> >
> > For PDE, this is what I propose
> >
> >
> >
> > It is recommended that all non-trivial changes should have a corresponding issue ( exceptions are cleanup, typo, releng, formatting, comparator issue, version change etc). Basically any change that changes the behaviour of eclipse should be tracked by an issue.
> >
> >
> >
> > All PRs without an issue should compulsorily  have “milestone” and “assignee” set in the PR.
> >
> >
> >
> > Enhancement and noteworthy items should compulsorily have a corresponding issue and enhancement/noteworthy label should be put. In case of regression, we must put regression label.
> >
> >
> >
> > Thanks and Regards,
> >
> > Vikas
> >
> >
> >
> > --
> >
> >
> >
> > _______________________________________________
> > pde-dev mailing list
> > pde-dev@xxxxxxxxxxx
> > To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/pde-dev