Re: [pde-dev] p2.gathering vs. generate.p2.metadata

[Andrew Niefer <aniefer@xxxxxxxxxx>]

The bundles you provided build fine
for me.

The log (copying 305 vs copying 1)  does
not indicate a problem by itself.  When p2.gathering=true, we publish
jars straight into a p2 repository.  
generate.p2.metadata had to copying
everything into a common staging area before creating the jar.  But
with p2.gathering=true,  we can sometimes avoid this step, and instead
create the jar using filesets that point to the files where-ever they are
on disk.  The [eclipse.gatherBundle] task is doing this work and does
not print to the log the number of files it finds.  (If you define
customBuildCallbacks, then we lose this optimization and then need to copy
the files into a staging area first to allow the callbacks to do stuff
on them).

If the build is failing later, you should
be able to see your bundles in the intermediate build repository that is
probably under
/hudson/jobs/org.mozilla.xulrunner.HEAD/workspace/build/buildRepo

-Andrew

From:	Jacek Pospychała <jacek.pospychala@xxxxxxxxx>
To:	"Eclipse PDE general developers list." <pde-dev@xxxxxxxxxxx>
Date:	08/05/2009 01:43 PM
Subject:	Re: [pde-dev] p2.gathering vs. generate.p2.metadata
Sent by:	pde-dev-bounces@xxxxxxxxxxx

---

Actually there's no Bundle-NativeCode.
Average manifest looks like this:

Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Bundle-Name
Bundle-SymbolicName: org.mozilla.xulrunner.win32.win32.x86;singleton:=true
Bundle-Version: 1.9.1.0_qualifier
Bundle-ClassPath: xulrunner/
Bundle-Vendor: %Bundle-Vendor
Bundle-localization: plugin
Eclipse-PlatformFilter: (& (osgi.ws=win32)
(osgi.os=win32)  (osgi.arch=x86))


In build.properties we clearly define what should be included
(this is whole build.properties file):

bin.includes = META-INF/,\
              
xulrunner/,\
              
plugin.properties


If you'd like to have a look, I posted all sources to
http://www.cs.put.poznan.pl/jpospychala/xulrunner-sources.zip
- I have only removed files from xulrunner/* directories in plug-ins, to
reduce zip size from 60M to 0,5M.

To recapture, whole build runs correctly, plugins and
features are built.
So next I add old generate.p2.metadata=true - this makes
that additionally content.jar and artifacts.jar are generated (yea!).
But then I replace that old stinky property with new p2.gathering=true
instead and suddenly nothing is getting built. The major difference can
be spotted in the build log, as outlined earlier....

do you have any clue?



2009/8/5 Andrew Niefer <aniefer@xxxxxxxxxx>

One thing to check, is if you are using Bundle-NativeCode with a selection-filter,
pde.build doesn't handle this very well. 
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=284784.
If this is the case, try adding Eclipse-PlatformFilter in addition to the
Bundle-NativeCode. 

-Andrew

From:	Jacek Pospychała <jacek.pospychala@xxxxxxxxx>
To:	"Eclipse PDE general developers list." <pde-dev@xxxxxxxxxxx>
Date:	08/05/2009 11:48 AM
Subject:	Re: [pde-dev] p2.gathering vs. generate.p2.metadata
Sent by:	pde-dev-bounces@xxxxxxxxxxx

---

Andrew, 
It's something that I'm trying to package. That's 3 simple plug-ins for
3 different platforms that just contain xulrunner/ with platform specific
libs. 
they don't look anything special to me, but I'll try to provide them in
source form. 


2009/8/5 Andrew Niefer <aniefer@xxxxxxxxxx>

Jacek, 
Where do you get xulrunner?  Is it somewhere I can download and try
this for myself? 

-Andrew

From:	Jacek Pospychała <jacek.pospychala@xxxxxxxxx>
To:	pde-dev@xxxxxxxxxxx
Date:	08/04/2009 09:27 AM
Subject:	[pde-dev] p2.gathering vs. generate.p2.metadata
Sent by:	pde-dev-bounces@xxxxxxxxxxx

---

hi, 

I have a build that uses generate.p2.metadata=true to generate p2
repository, but wanted to replace it with 
p2.gathering=true to take the advantage of p2.category.definition=<url.to.category.xml>

Unfortunately, simply changing generate.p2.metadata to p2.gathering doesn't
help, but rather breaks the build. 
With the former I get this in build log: 


init:

gather.bin.parts:
   [mkdir] Created dir: /hudson/jobs/org.mozilla.xulrunner.HEAD/workspace/build/tmp/eclipse/plugins/org.mozilla.xulrunner.gtk.linux.x86_1.9.1.0_v20090804
    [copy] Copying 305 files to /hudson/jobs/org.mozilla.xulrunner.HEAD/workspace/build/tmp/eclipse/plugins/org.mozilla.xulrunner.gtk.linux.x86_1.9.1.0_v20090804

apitools.generation:

customAssembly: 

whereas with p2.gathering no files are copied to plug-in even if it's build.properties
is correct: 


publish.bin.parts:
   [mkdir] Created dir: /hudson/jobs/org.mozilla.xulrunner.HEAD/workspace/build/plugins/org.mozilla.xulrunner.gtk.linux.x86/org.mozilla.xulrunner.gtk.linux.x86_1.9.1.0_v20090804
    [copy] Copying 1 file to /hudson/jobs/org.mozilla.xulrunner.HEAD/workspace/build/plugins/org.mozilla.xulrunner.gtk.linux.x86

apitools.generation:
[eclipse.gatherBundle] Generating metadata for ..
[eclipse.gatherBundle] Generation completed with success [3 seconds].



Do you know what might be wrong? 
Should I change anything else to make p2.gathering work? 

thanks 

Jacek 

_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev



_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev

_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev



_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev

_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev