Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [papyrus-rt-dev] Completed — Re: Request for Commit Process Exception: Façade Refactoring

I can confirm that the problem in Master-Codegen is not an issue. That build job is unstable due to an incorrect test in a new bundle, and I never managed to make the Gerrit-Codegen job trigger that junit test. But otherwise this doesn't affect any functionality in codegen or elsewhere. I'll update the test and try to add it to the Gerrit build again.

--
Ernesto Posse
Zeligsoft



On Fri, Feb 3, 2017 at 1:18 PM Christian Damus <give.a.damus@xxxxxxxxx> wrote:
Hi again,

The refactoring is pushed to Gerrit and the builds seem to be green, except for one test failure in Master-Codegen that is 36 builds old, so probably unrelated.

Cheers,

Christian

On Jan 31, 2017, 10:09 -0500, Christian Damus <give.a.damus@xxxxxxxxx>, wrote:
Hi, Team,

In order not to block the fixing of bugs in capsule structure inheritance (e.g., 511380) and to get past the hurdle of the modelled façade refactoring, I would like to merge Gerrit 89958 as soon as possible.  After, of course, review by some suitable volunteer (don't worry — at least half of it comprises icon files, generated model interfaces, the generated UML extensions that don't have custom code, plus loads of tests 😉).

The problem is that this commit cannot pass the Gerrit builds as currently structured and I don't see any way to tease it apart into a sequence of commits that can each be individually reviewed and merged before the next.  The reason is that, although from an API perspective for most clients the modelled façade is a drop-in replacement for the API currently on master, because now the façade objects are EObjects, they are recognized differently by UI frameworks such as the Papyrus Properties View.  Trying to commit the façade API first would break the UI tests, but the UI cannot be changed in advance because the façade objects would not yet be EObjects.  Moreover, because the modelled façade is a drop-in replacement for the existing API, I cannot first add the new façade in its entirety, then switch the UI over to using it, and finally delete the old façade because the API names are all identical:  they cannot both be built and deployed together (that is the whole point of the drop-in replacement).

The only way I see out of this is just to push the change directly to master once the reviewer(s) is/are satisfied with it.  All of our JUnit tests for affected components pass when run locally and the tooling seems still to work.  Unless somebody can suggest a solution that I'm not seeing?

Comments welcome, as are reviewers, of course.

Thanks,

Christian
_______________________________________________
papyrus-rt-dev mailing list
papyrus-rt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/papyrus-rt-dev
--
Ernesto Posse
Zeligsoft

Back to the top