[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [papyrus-rt-dev] Integration of the rts model library in the core
|
| Some comments inline below.
/Charles
Hi all, I restart the work on these bugs [1] this week. I wanted to integrated quite fast, as it impacts the architecture of the tool, especially having some impact on code generator and tooling. The contribution on gerrit [2] is ongoing, we are only facing now some small issues on the integration/testing part. Thanks to Ernesto, the contribution for the testing of the code generator was updated. I can easily now integration the contribution if it is OK with everyone, I just have to remove the reviewer Hudson-ci from the list of reviewers, and its -1 will be removed from the votes. Some historic discussion already happened on that mailing list [3] However, before integrating this contribution, I wanted to be sure everyone was OK on it: - I created a new plugin for the rts model library. This model is supposed to be independent from any implementation language, so I added it to the core part of Papyrus, with no link to C++ as it was before. In fact, RTS model library and the runtime were distributed in the same plugin historically for convenience.
<cr> I don’t think it should be in Papyrus Core. It really only belongs in Papyrus-RT. This library and the runtime is specific to UML-RT and therefore to Papyrus-RT.
</cr>
- I moved the library in this new plugin, cleaned bit the dependencies, and I would like also to remove the extension as a Papyrus library. This declaration is used only for a tooling point of view, to be listed in the list of available registered libraries, it has no impact on the element resolution when model is loaded. Removing it would remove the dependency of the library to Papyrus, thus making it usable on standalone model transformation / code generation / etc.
Regarding the part about the extension, does that mean it will no longer show in the “Load registered package”? I agree with this as long as it is automatically included in models. Actually, since Ericsson is (or planning on) using Papyrus-RT as a DSML platform that may not require the codegen or RTS, automatic inclusion may not be an ideal solution, but then you should also be able to remove stuff when creating a DSML. However, it must be tied to the UML-RT code generation and the actual runtime. So if you are planning on using one of these, all three must be available in the toolset. Perhaps an option for UML-RT code generation on project/model setup, with default on inclusion (as I believe it to be the most common option)?
- I changed the pathmap location. It now points to the new plugin, so there are no impacts on the existing models referencing the model library by the pathmap (which should be always the case). - The o.e.prt.rts only contains the generated C++ code. As it is C++ dependent, I would advise to make it obvious in the namespace. - Does everyone agree on that changes? Once the contribution is merged, I can finish the work on the system protocol identification (and system classes by the way) relying on default language framework & specific profile Regards, Rémi [1] Bug 488104: Identify UML-RT system classes in UMLRT-RTS model libraryBug 477721: Decide on common principle to identify system protocols, including base protocol in UML-RT model library ------------------------------------------------------- Rémi SCHNEKENBURGER +33 (0)1 69 08 48 48 CEA Saclay Nano-INNOV Institut CARNOT CEA LIST
|
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail
