Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [paho-dev] paho Android Service and Sample App with Gradle
Hi,

any updates on this? I can just submit my changes via Gerrit if this helps. 
  
Thanks,
Sandro

Am 27.02.2015 um 17:38 schrieb Benjamin Cabé <benjamin@xxxxxxxxxxx>:

Github pull requests are perfectly fine, but they are usually meant to be used with Eclipse projects that have their repos hosted on Github. Such repos have dedicated hooks that easily allow to check if the commits in the proposed PR are from a committer with a valid CLA in place. A similar check is happening when a PR is submitted via Gerrit.
However, Ian, you can cherry pick Sandro commits as per https://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions#Git , granted that they have been Signed-off-by'd

HTH
Benjamin –


Benjamin Cabé

Eclipse Foundation
+33 (0) 619196101


De : Ian Craggs <icraggs@xxxxxxxxxxxxxxxxxxxxxxx>
Répondre à : General development discussions for paho project <paho-dev@xxxxxxxxxxx>
Date : vendredi 27 février 2015 16:57
À : <paho-dev@xxxxxxxxxxx>
Objet : Re: [paho-dev] paho Android Service and Sample App with Gradle

Hi Sandro (and Jeff),

it's not a problem for me to accept your idea -- I thank you for making the contribution :-)

So, Benjamin might correct me here, but it's my understanding that we can't currently accept contributions via github pull requests.   They have to be via Eclipse bugzilla or Gerrit, because of the Eclipse IP/legal process.  I also believe that this is something the Eclipse Foundation is looking into, but that any solution isn't necessarily simple or likely to happen soon.

Benjamin?

Ian


On 02/27/2015 03:30 PM, Sandro Kock wrote:
Hi,

I have submitted my pull request via github [1], if it is easier is can submit it to [2].

Sandro



Am 26.02.2015 um 03:03 schrieb Jeff Prestes <jeffprestes@xxxxxxxxx>:

Hey guys,

Thanks Ian for acceping our idea.

Sandro feel free to see my repository: https://github.com/jeffprestes/AndroidMQTTDemo
I didn't changed any functionality. I only changed it to Android Studio be able to open it easily. If you have any more improvements feel free to submit your version. If you have any questions don't hesitate to contact me.

Best!

-Jeff Prestes


2015-02-25 17:36 GMT-03:00 Sandro Kock <sandro.kock@xxxxxxxxx>:
Hi Ian,

I had a nice chat with Benjamin today at the Embedded World. I will look into pushing my code tomorrow, before that I will check if Jeff has made something different/ better and merge both sources. 

Sandro

Am 25.02.2015 um 14:01 schrieb Ian Craggs <icraggs@xxxxxxxxxxxxxxxxxxxxxxx>:

Hi Jeff,

the usual way of accepting contributions to Paho is through Gerrit, the code review project.  Gerrit provides an easy way to evaluate the contribution.   A guide to making contributions this way is in the CONTRIBUTING file in the repository:

http://git.eclipse.org/c/paho/org.eclipse.paho.mqtt.java.git/about/

I hope that provides you with all the information, you need.  If not please ask.

Ian


On 02/24/2015 05:28 PM, Jeff Prestes wrote:
Hi Ian,
Sandro and I have ported it and the new version are available in our github repository.
How could we submit them to the community to you evaluate and upgrade project's repository?
Thanks and best regards,
-Jeff Prestes
Em 24/02/2015 11:49, "Ian Craggs" <icraggs@xxxxxxxxxxxxxxxxxxxxxxx> escreveu:
I am happy to move to a Gradle build if that is the consensus.  I'm not able to do that for the next two or three weeks myself as I'm preparing my for my MQTT-SN talk at EclipseCon.  All contributions are welcome :-)

Ian


On 02/24/2015 12:25 PM, Manuel Domínguez Dorado wrote:
+1

2015-02-23 12:36 GMT+01:00 Jeff Prestes <jeffprestes@xxxxxxxxx>:
Hi Sandro and all,

I believe it would be great as almost of all Android developers are migrating to Android Studio.

Cheers,

-Jeff

2015-02-23 7:09 GMT-03:00 Sandro Kock <sandro.kock@xxxxxxxxx>:

Hi,

i just updated the Sample App to use the new released Android Service 1.0.2.  The source is available at https://github.com/sandro-k/org.eclipse.paho.android.service.sample .
What is the current opinion about dropping the ADT support and using the Gradle only version? 

Sandro


Am 12.12.2014 um 11:27 schrieb Sandro Kock <sandro.kock@xxxxxxxxx>:

Hi Benjamin,

even with Android Studio 1.0 released and using Gradle as an Android build makes dependency management much easier. There is currently no direkt Gradle support for ADT [1] but ADT can be configured to build Android Gradle projects. So I am not sure how to go with that.

Sandro


Am 12.12.2014 um 11:09 schrieb Benjamin Cabé <benjamin@xxxxxxxxxxx>:

Hi Sandro,

Cool, thanks!
Actually, I think it’d be great if you’d directly contribute your version of the sample using Gerrit? [1] I don’t know though if it’d make sense to try and maintain a sample compatible with both ADT and Android Studio/Gradle, or just go for a Gradle only version…

Benjamin –




De : Sandro Kock <sandro.kock@xxxxxxxxx>
Répondre à : General development discussions for paho project <paho-dev@xxxxxxxxxxx>
Date : vendredi 12 décembre 2014 10:58
À : <paho-dev@xxxxxxxxxxx>
Objet : [paho-dev] paho Android Service and Sample App with Gradle

Hey Everyone,

I have been playing around with the paho Android service the last days and wanted to build the Sample App with Gradle. For some reason the org.eclipse.paho.android.service available at [1] includes the android support library v4 as a dependency. 

$ gradle -q :app:dependencies

_debugApk - ## Internal use, do not manually configure ##
+--- com.android.support:support-v4:21.0.3
|    \--- com.android.support:support-annotations:21.0.3
\--- org.eclipse.paho:org.eclipse.paho.android.service:1.0.1-SNAPSHOT
     +--- org.eclipse.paho:org.eclipse.paho.client.mqttv3:1.0.1-SNAPSHOT
     \--- com.google.android:support-v4:r7

_debugCompile - ## Internal use, do not manually configure ##
+--- com.android.support:support-v4:21.0.3
|    \--- com.android.support:support-annotations:21.0.3
\--- org.eclipse.paho:org.eclipse.paho.android.service:1.0.1-SNAPSHOT
     +--- org.eclipse.paho:org.eclipse.paho.client.mqttv3:1.0.1-SNAPSHOT
     \--- com.google.android:support-v4:r7
....

compile - Classpath for compiling the main sources.
+--- com.android.support:support-v4:21.0.3
|    \--- com.android.support:support-annotations:21.0.3
\--- org.eclipse.paho:org.eclipse.paho.android.service:1.0.1-SNAPSHOT
     +--- org.eclipse.paho:org.eclipse.paho.client.mqttv3:1.0.1-SNAPSHOT
     \--- com.google.android:support-v4:r7
     
....     


That is why I had to use 

compile (group: 'org.eclipse.paho', name: 'org.eclipse.paho.android.service', version: '1.0.1-SNAPSHOT') {
  exclude module: 'support-v4'
} 

to properly build the sample App.

All changes I made to the App are available at [2]. 

Maybe this helps someone to build there Android Apps with Gradle and Paho :)

Sandro



_______________________________________________ paho-dev mailing list paho-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/paho-dev
_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev



_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev


_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev



--
---
Manuel Domínguez Dorado
ingeniero ARROBA ManoloDominguez PUNTO com
http://www.ManoloDominguez.com


_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev

--
Ian Craggs
icraggs@xxxxxxxxxx                 IBM United Kingdom
Paho Project Lead; Committer on Mosquitto

_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev


_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev

--
Ian Craggs
icraggs@xxxxxxxxxx                 IBM United Kingdom
Paho Project Lead; Committer on Mosquitto
_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev


_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev

_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev



_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev

--
Ian Craggs
icraggs@xxxxxxxxxx                 IBM United Kingdom
Paho Project Lead; Committer on Mosquitto
_______________________________________________ paho-dev mailing list paho-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/paho-dev
<64BFBB6C-FC2D-4129-971F-33935977CC64[28].png>_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev

Back to the top