Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [paho-dev] Patch for sending Gateway Info Messages

Hi Mohammad,

thanks!  Can you submit it with Gerrit please?  Gerrit makes contributions much easier to review and accept, although it is a bit of work to get going.  

Here's some help on contributing with Gerrit.

Contributing a patch

The Paho repositories are accessed through Gerrit, the code review project, which makes it possible for anybody to clone the repository, make changes and push them back for review and eventual acceptance into the project.

To do this, you must follow a few steps. The first of these are described at

  • Contributing via git

  • Sign the Eclipse CLA

  • Use a valid commit record, including a signed-off-by entry.

There are further details at

Once the patch is pushed back to Gerrit, the project committers will be informed and they will undertake a review of the code. The patch may need modifying for some reason. In order to make amending commits more straightforward, the steps at https://git.eclipse.org/r/Documentation/cmd-hook-commit-msg.html should be followed. This automatically inserts a "Change-Id" entry to your commit message which allows you to amend commits and have Gerrit track them as the same change.

What happens next depends on the content of the patch. If it is 100% authored by the contributor and is less than 1000 lines (and meets the needs of the project), then it can be committed to the main repository. If not, more steps are required. These are detailed in the legal process poster.


Ian

On 10/28/2014 10:38 AM, Mohammad Jamal wrote:
I have implemented the handling of search GW Messages and sending GWInfo Messages.

Attached the patch

Ian , Please review...

Regards,
Md.Jamal

-------------------------------------------------------------------------------------------------------------------------------
[ C-DAC is on facebook. Kindly follow us on the following url:  https://www.facebook.com/CDACINDIA ]

This e-mail is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. If you are not the
intended recipient, please contact the sender by reply e-mail and destroy
all copies and the original message. Any unauthorized review, use,
disclosure, dissemination, forwarding, printing or copying of this email
is strictly prohibited and appropriate legal action will be taken.
-------------------------------------------------------------------------------------------------------------------------------


-------------------------------------------------------------------------------------------------------------------------------
[ C-DAC is on Social-Media too. Kindly follow us at:
Facebook: https://www.facebook.com/CDACINDIA & Twitter: @cdacindia ]

This e-mail is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. If you are not the
intended recipient, please contact the sender by reply e-mail and destroy
all copies and the original message. Any unauthorized review, use,
disclosure, dissemination, forwarding, printing or copying of this email
is strictly prohibited and appropriate legal action will be taken.
-------------------------------------------------------------------------------------------------------------------------------



_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev

-- 
Ian Craggs                          
icraggs@xxxxxxxxxx                 IBM United Kingdom
Paho Project Lead; Committer on Mosquitto


Back to the top