Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [paho-dev] Tabs vs. spaces in the codebase
Completely agree Paho should follow Eclipse conventions and if I'm misinterpreting, it would be good to be clear! :-) thanks all. 

On Wednesday, November 13, 2013, Chris Jenkins wrote:
I interpret that to mean that the tab width should be 4 and that tab characters should be used (rather than multiple spaces) to indent. Certainly, if I get a fresh install of the Eclipse IDE then it seems to be set up that way. This differs from the Sun's Java coding conventions which state that "Four spaces should be used as the unit of indentation" and that "Tabs must be set exactly every 8 spaces (not 4)".

My two cents are that Paho should follow the Eclipse conventions.


On 13 November 2013 21:04, Andy Piper <andypiperuk@xxxxxxxxx> wrote:
I believe Eclipse Coding Conventions (which obviously have a Java slant historically) are based on Sun's: http://wiki.eclipse.org/Coding_Conventions

"We indent with tabs, 4 spaces wide" - which I interpret to mean tabs should be 4 space character, not a tab character.

#needsfixing


On Wednesday, November 13, 2013, Michael Klishin wrote:
While working on [1], I've noticed that different
parts of the codebase use tabs, while some use spaces.

Have the Paho team considered settling on either option
and enforcing it?

This is not a top priority issue but it makes it life of patch reviewers harder
*and* makes it harder for contributors to make sure your patch has a good
signal/noise ratio.


--
Andy Piper | Kingston upon Thames, London (UK)
blog: http://andypiper.co.uk   |   skype: andypiperuk
twitter: @andypiper  |  images: http://www.flickr.com/photos/andypiper


_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/paho-dev




--
Andy Piper | Kingston upon Thames, London (UK)
blog: http://andypiper.co.uk   |   skype: andypiperuk
twitter: @andypiper  |  images: http://www.flickr.com/photos/andypiper

Back to the top