| Re: [orion-dev] continute |
|
Hi All I fixed the problem I had issue with my commit ID. I did the push again https://git.eclipse.org/r/#/c/57907/ could you please review this change ? Regards, Yossi From: Balan, Yossi
Hi All I think I have some problem with this change. I tried to do fetch rebase and then I got new commit and I didn’t succeed to do git commit –amend. ( I got other commit )
So I want to create new push in gerrit and I created new commit and abandoned the
https://git.eclipse.org/r/#/c/51423/. I did the push access with user/password from
https://git.eclipse.org/r/#/settings/http-password my user name - ybalanpgl Now when I tried to do push I got error
This is my commit
Could you please advise me? Regards, Yossi
From:
orion-dev-bounces@xxxxxxxxxxx [mailto:orion-dev-bounces@xxxxxxxxxxx]
On Behalf Of Anthony Hunter I cannot rebase your change
https://git.eclipse.org/r/#/c/51423/ in gerrit, there are recent changes in Orion you need to synchronise with.
Do you submit my change ?
https://git.eclipse.org/r/#/c/51423/ Hi Jhon Thanks for the help and for the answers. One thing about the change I create 3 patch set because the comment of Silenio Quarti. https://git.eclipse.org/r/#/c/51423/ you did Abandoned because it is duplicate. Is it ok ? Is it ok to ask those question in this mail list ? Regards, Yossi From:
orion-dev-bounces@xxxxxxxxxxx [mailto:orion-dev-bounces@xxxxxxxxxxx]
On Behalf Of John Arthorne Hi Yoshi, 1. There is nothing more you needed to do here. However sending your gentle reminder was a good idea - sometimes these things just fall off the radar. Especially in this case because there was no evident bug
or adverse user behavior. We'll try to get it reviewed ASAP. 2. We don't actually run maintenance builds for previous releases of Orion. Once it is accepted in master you could also submit a change against an older branch if it is helpful for you, but you will have to
take care of building that old branch yourself. 3. Yes it is possible to only make the change against an older branch, but we like to avoid it. if it makes sense to change it in Orion 5, it is hard to argue we shouldn't also do it in the latest release. Otherwise
you or others would hit a regression when moving up to a newer release. John
Hi All I am new on all the contribution process and I have few questions : 1.
I did the process and fix bug 468485 with this correction -
https://git.eclipse.org/r/#/c/52033/ but I still didn’t merge . do I need to do more
steps ? 2.
About this correction I fixed it on orion8 does it will be updated also orion5 / 9/ 10 ? 3.
Is it possible to fix only for orion 5? Regards, Yossi _______________________________________________
|
